Closed
Bug 937474
Opened 12 years ago
Closed 12 years ago
Eliminate unsafe uses of cloneNode() with no arguments and importNode() with no boolean arg from gaia code
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.3 Sprint 5 - 11/22
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
3.71 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
Much like bug 937462 but for gaia.
|
Assignee | |
Comment 1•12 years ago
|
||
Jonas, are you the right reviewer here?
There seem to be no uses of importNode in gaia code, yay.
Attachment #830630 -
Flags: review?(jonas)
|
|
Assignee | |
Comment 2•12 years ago
|
||
And https://github.com/mozilla-b2g/gaia/pull/13605 I guess, though somehow the commit message there got messed up....
Attachment #830630 -
Flags: review?(jonas) → review+
Did you also look for calls like .cloneNode(expr) where 'expr' could possibly be 'undefined'
|
|
Assignee | |
Comment 4•12 years ago
|
||
Those aren't a problem because we have always treated them as cloneNode(false), continue to do so now, and will in the future.
|
|
Assignee | |
Comment 5•12 years ago
|
||
So how do I actually get this landed in Gaia? Pull request seems to be getting ignored....
Flags: needinfo?(jonas)
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
Whiteboard: [need landing in gaia]
|
||
Comment 6•12 years ago
|
||
Assignee: nobody → bzbarsky
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: needinfo?(jonas)
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [need landing in gaia]
Target Milestone: --- → 1.3 Sprint 5 - 11/22
You need to log in
before you can comment on or make changes to this bug.
Description
•