[Settings] Keyboard issues in settings

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: harly, Assigned: mihai)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Comment 1

4 years ago
1. Settings->Wi-Fi->Connect with WPS: Pin is 4 or 8 digits, therefore, keyboard should use number keypad
2. Settings->Call Settings->Voicemail: Keyboard should raise up automatically
3. Settings->Cellular & Data->Data settings: Typing in APN field, keyboard should not have predict word, and typing in password field, keyboard should use password keyboard
4. Settings->Cellular & Data->Message settings: Typing in APN field, keyboard should not have predict word, and typing in password field, keyboard should use password keyboard
5. Settings->Cellular & Data->A-GPS settings: Typing in APN field, keyboard should not have predict word, and typing in password field, keyboard should use password keyboard
6. Settings->Bluetooth->Rename my device: Keyboard should raise up automatically
(Reporter)

Updated

4 years ago
Depends on: 936394
(Reporter)

Updated

4 years ago
Blocks: 936394
No longer depends on: 936394
(Assignee)

Updated

4 years ago
Assignee: nobody → mihai
Created attachment 8340710 [details]
Pull Request #14236 - Update input field types and trigger kb

Correctness fixes for input types/inputmodes and trigger input focus for mentioned Settings subpanels.
Attachment #8340710 - Flags: review?(rlu)
Comment on attachment 8340710 [details]
Pull Request #14236 - Update input field types and trigger kb

Hi Mihai,

Thanks for addressing this issue!
Since the changes all happen in settings app, I'll redirect this to settings peer/owner.

Arthur, could you help?
Thanks.
Attachment #8340710 - Flags: review?(rlu) → review?(arthur.chen)
Arthur, not sure you've seen this, can you check out the patch for this bug?
Flags: needinfo?(arthur.chen)
Sorry for the delay. I have a couple 1.3+ patch review requests. Will try to review it soon.
Flags: needinfo?(arthur.chen)
Comment on attachment 8340710 [details]
Pull Request #14236 - Update input field types and trigger kb

Thank you for the patch! Please check my comments in github.
Attachment #8340710 - Flags: review?(arthur.chen)
Comment on attachment 8340710 [details]
Pull Request #14236 - Update input field types and trigger kb

Thanks for the feedback, Arthur! The patch is now updated, let me know if it looks good.
Attachment #8340710 - Flags: review?(arthur.chen)
Comment on attachment 8340710 [details]
Pull Request #14236 - Update input field types and trigger kb

We are almost there! Please use "else if" to reduce the nest level. And also make sure that we the travis is green.
Attachment #8340710 - Flags: review?(arthur.chen)
(In reply to Arthur Chen [:arthurcc] from comment #8)
> Comment on attachment 8340710 [details]
> Pull Request #14236 - Update input field types and trigger kb
> 
> We are almost there! Please use "else if" to reduce the nest level. And also
> make sure that we the travis is green.

Hey Arthur, replied to your comment on GitHub. I don't think it is possible to avoid the nesting without refactoring the initial conditional, which might lead to undesired side-effects.

Let me know what you think about this.
Flags: needinfo?(arthur.chen)
Hi Mihai, please check my github comment.
Flags: needinfo?(arthur.chen)
Comment on attachment 8340710 [details]
Pull Request #14236 - Update input field types and trigger kb

Updated according to your suggestion -- note the travis error is not related to the patch.
Attachment #8340710 - Flags: review?(arthur.chen)
Comment on attachment 8340710 [details]
Pull Request #14236 - Update input field types and trigger kb

Thank you for the effort, Mihai! r=me.

Please re-run travis and make sure it's green before merging as possible. I know there are still chances to get false alarm from travis. But submitting a commit with green travis helps to find bad commits more easily when something is actually broken. Thanks!
Attachment #8340710 - Flags: review?(arthur.chen) → review+
Thanks Arthur! Landed on master:
https://github.com/mozilla-b2g/gaia/commit/116bfb8edb1780079a1988dd6bd828b0b77fa7b3
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.