937507 - [Settings] Value selector style for connect with WPS is different from building blocks

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Harly Hsu[:harly]]

Attachment: WPS

Settings->Wi-Fi->Connect with WPS: Tap My PIN connection or AP PIN connection will show a value selector with a text "Any". It is different from other value selector in Settings.

Comment 1

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #13677 - Fix value selector styling

Wrapped selector with appropriate BB style (similar to Settings > Languages value selector).

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 831912 [details]
Pull Request #13677 - Fix value selector styling

r=me. Thank you!

Comment 3

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Thanks Arthur! Landed on master:
https://github.com/mozilla-b2g/gaia/commit/1c6db99e4946ff6c165c5b4d64f077b2202d85db

Comment 4

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Comment on attachment 831912 [details]
Pull Request #13677 - Fix value selector styling

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Setings > WiFi > Connect with WPS > value selector styling
[User impact] if declined: Low
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low/None (updated value selector to use BB)
[String changes made]: No