[Settings] Confirmation prompt with no title when resetting phone

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: harly, Assigned: mihai)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

4 years ago
Created attachment 830707 [details]
device-2013-11-12-170409.png

In Settings->Device information->More Informaiton->Reset Phone, when user tap reset phone, system will display a warning prompt.

Recommend to move Caution to the title of the warning prompt.
(Reporter)

Updated

4 years ago
Blocks: 936394
(Assignee)

Updated

4 years ago
Assignee: nobody → mihai
Created attachment 8340116 [details]
Pull Request #14189 - Update prompt popup

Changed the existing confirm window to the BB version and added the title field.
Attachment #8340116 - Flags: review?(arthur.chen)
Created attachment 8340118 [details]
Screenshot after patch

This is how it looks after applying the patch.
(Reporter)

Comment 3

4 years ago
Hi Mihai,
The screenshot looks good, but it would be great if we could change the text of button "OK" to "Reset".
Thanks 

(In reply to Mihai Cirlanaru [:mihai][:mcirlanaru] from comment #2)
> Created attachment 8340118 [details]
> Screenshot after patch
> 
> This is how it looks after applying the patch.
Created attachment 8340587 [details]
Screenshot after patch (updated)

Updated, thanks for the feedback Harly!
Attachment #8340118 - Attachment is obsolete: true
Comment on attachment 8340116 [details]
Pull Request #14189 - Update prompt popup

Good job! r=me.
Attachment #8340116 - Flags: review?(arthur.chen) → review+
Thanks Arthur! Landed on master:
https://github.com/mozilla-b2g/gaia/commit/bcc7b8982e7f18a8c010d32a09cb1cdbf670c36b
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.