Closed Bug 937533 Opened 9 years ago Closed 9 years ago

[Settings] Confirmation prompt with no title when resetting phone

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: harly, Assigned: mihai)

References

Details

Attachments

(3 files, 1 obsolete file)

In Settings->Device information->More Informaiton->Reset Phone, when user tap reset phone, system will display a warning prompt.

Recommend to move Caution to the title of the warning prompt.
Blocks: 936394
Assignee: nobody → mihai
Changed the existing confirm window to the BB version and added the title field.
Attachment #8340116 - Flags: review?(arthur.chen)
Attached image Screenshot after patch (obsolete) —
This is how it looks after applying the patch.
Hi Mihai,
The screenshot looks good, but it would be great if we could change the text of button "OK" to "Reset".
Thanks 

(In reply to Mihai Cirlanaru [:mihai][:mcirlanaru] from comment #2)
> Created attachment 8340118 [details]
> Screenshot after patch
> 
> This is how it looks after applying the patch.
Updated, thanks for the feedback Harly!
Attachment #8340118 - Attachment is obsolete: true
Comment on attachment 8340116 [details]
Pull Request #14189 - Update prompt popup

Good job! r=me.
Attachment #8340116 - Flags: review?(arthur.chen) → review+
Thanks Arthur! Landed on master:
https://github.com/mozilla-b2g/gaia/commit/bcc7b8982e7f18a8c010d32a09cb1cdbf670c36b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.