937533 - [Settings] Confirmation prompt with no title when resetting phone

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Harly Hsu[:harly]]

Attachment: device-2013-11-12-170409.png

In Settings->Device information->More Informaiton->Reset Phone, when user tap reset phone, system will display a warning prompt.

Recommend to move Caution to the title of the warning prompt.

Comment 1

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #14189 - Update prompt popup

Changed the existing confirm window to the BB version and added the title field.

Comment 2

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Screenshot after patch

This is how it looks after applying the patch.

Comment 3

[Harly Hsu[:harly]]

Hi Mihai,
The screenshot looks good, but it would be great if we could change the text of button "OK" to "Reset".
Thanks 

(In reply to Mihai Cirlanaru [:mihai][:mcirlanaru] from comment #2)
> Created attachment 8340118 [details]
> Screenshot after patch
> 
> This is how it looks after applying the patch.

Comment 4

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Screenshot after patch (updated)

Updated, thanks for the feedback Harly!

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8340116 [details]
Pull Request #14189 - Update prompt popup

Good job! r=me.

Comment 6

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Thanks Arthur! Landed on master:
https://github.com/mozilla-b2g/gaia/commit/bcc7b8982e7f18a8c010d32a09cb1cdbf670c36b