937534 - The list is going up 2 levels when pressing back button in the bookmark folders

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Flaviu Cos]

Environment: 
Device: Asus Transformer Tab (Android 4.0.3)
Build: Nightly 28.0a1 (2013-11-11)

Steps to reproduce:
1. Sync fennec with a pc.
2. Wait until all the bookmarks are imported from the synced device.
3. From the awesomescreen tap on the bookmarks.
4. Tap on 'Desktop Bookmarks' folder.
5. Tap on 'Bookmarks Menu' folder.
6. Tap on 'Mozilla Firefox' folder.
7. Tap the android back button.

Expected result:
The list is going up one level.

Actual result:
When tapping android back button the list is going up 2 levels.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

I can not reproduce this in today's trunk build on a HTC One X+ Android 4.3, Sony Tablet S Android 4.0 and a 2013 Nexus 7 Android 4.3.

Comment 2

[Flaviu Cos]

I borrowed the following devices from my colleagues:
Htc One X (Android 4.1.1);
Sony Tablet S (Android 4.0.3);
Nexus 7 (Android 4.3);
The bug is reproducible on every of the mentioned devices.
Please check this video: http://www.youtube.com/watch?v=anKtuau0BII

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

Hm, yes now I can reproduce.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Do we have a regression range here? Is this a recent regression? Not sure we need to track or just be open to a low risk uplift nomination if available within the week (as we are nearing end of 26 beta)

Comment 5

[Flaviu Cos]

Good build 08.21.2013;
Bad build 08.22.2013;
Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d136c8999d96&tochange=2ab07dec6404
Tested on Google Nexus 10 (Android 4.3).

Comment 6

[Aaron Train [:aaronmt]]

fig branch merge to mozilla-central with dozens of changesets. Sriram, or Lucas, do you need a bi-sect from that?

Comment 7

[Lucas Rocha (:lucasr)]

(In reply to Aaron Train [:aaronmt] from comment #6)
> fig branch merge to mozilla-central with dozens of changesets. Sriram, or
> Lucas, do you need a bi-sect from that?

Not sure it would be trivial to do given how many broken state we had while developing in fig. I'll debug it manually.

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

This shipped in FF24 & FF25 so it's not a recent regression to the point that we'd take a late landing for it.  It's not ideal user experience but can probably ride the trains one more release (nominate uplift to Aurora FF27 if low risk fix available in time).

Comment 9

[Aaron Train [:aaronmt]]

(In reply to [e-mail] [:lsblakk] from comment #8)
> This shipped in FF24 & FF25 so it's not a recent regression to the point
> that we'd take a late landing for it.  It's not ideal user experience but
> can probably ride the trains one more release (nominate uplift to Aurora
> FF27 if low risk fix available in time).


What? This is new to 26.

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

(In reply to Aaron Train [:aaronmt] from comment #9)
> (In reply to [e-mail] [:lsblakk] from comment #8)
> > This shipped in FF24 & FF25 so it's not a recent regression to the point
> > that we'd take a late landing for it.  It's not ideal user experience but
> > can probably ride the trains one more release (nominate uplift to Aurora
> > FF27 if low risk fix available in time).
> 
> 
> What? This is new to 26.

My mistake, confusing good/bad builds on nightly with releases.  I see, thanks - let's find the broken patchset and see if a backout is an option at this stage.

Comment 11

[Lucas Rocha (:lucasr)]

Attachment: Only handle BACK key on ACTION_UP in Bookmarks page (r=mfinkle)

Comment 12

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/9aa627b04ef3

Comment 13

[Lucas Rocha (:lucasr)]

Comment on attachment 8335953 [details] [diff] [review]
Only handle BACK key on ACTION_UP in Bookmarks page (r=mfinkle)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new about:home (bug 862793)
User impact if declined: Bookmark navigation with Android's BACK button feels broken.
Testing completed (on m-c, etc.): Just pushed to fx-team. Let's bake this in Nightly for a couple days and then uplift to Aurora/Beta. 
Risk to taking this patch (and alternatives if risky): Low, very trivial change.
String or IDL/UUID changes made by this patch: n/a

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

Triage drive by, next Monday is the go-to-build for mobile beta so we'll check back before then.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9aa627b04ef3

Comment 16

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8e85dacac5de

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Please consolidate your pushes to Aurora in the future. Doing separate pushes leads to a lot of extra jobs being run and we're already hurting for Tegra capacity. Thanks :)

Comment 18

[Flaviu Cos]

Verified as fixed in build: Nightly 28.0a1 (2013-11-22).
Device: Asus Transformer Tab (Android 4.0.3)

Comment 19

[Flaviu Cos]

The bug is still reproducible on build: Aurora 27.0a2 (2013-11-22).
Device: Asus Transformer Tab (Android 4.0.3)

Comment 20

[Lucas Rocha (:lucasr)]

(In reply to flaviu.cos from comment #19)
> The bug is still reproducible on build: Aurora 27.0a2 (2013-11-22).
> Device: Asus Transformer Tab (Android 4.0.3)

I pushed this patch to Aurora one hour ago. It's not in the latest Aurora build yet I suppose.

Comment 21

[Flaviu Cos]

Verified as fixed in build: Aurora 27.0a2 (2013-11-24).
Device: Asus Transformer Tab (Android 4.0.3)

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e20d9c479ea2

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/e20d9c479ea2

Comment 24

[Flaviu Cos]

Verified as fixed in build: 26.0b1 beta 8 (2013-11-26).
Device: Asus Transformer Tab (Android 4.0.3)