Closed Bug 937539 Opened 11 years ago Closed 11 years ago

Cmd+Alt+F opens find/replace in the Debugger's editor

Categories

(DevTools :: Debugger, defect, P2)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(firefox26 unaffected, firefox27 fixed, firefox28 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 28
Tracking Flags:
Tracking Status
firefox26 --- unaffected
firefox27 --- fixed
firefox28 --- fixed

People

(Reporter: vporof, Assigned: vporof)

Details

(Keywords: regression, Whiteboard: [good first verify])

Attachments

(2 files, 1 obsolete file)

dbg-find.patch
3.08 KB, patch
anton
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review
patch for aurora
3.27 KB, patch
Details | Diff | Splinter Review 
It used to be "find in all files". It's now "find and replace".
Sounds like we need to do the same thing as in bug 929234?
Flags: needinfo?(anton)
Yeah, looks similar. I didn't even know we had this shortcut!
Flags: needinfo?(anton)
Taking this as there's currently no way to start searching in all files apart from the keyboard shortcut or manually typing an "!" in the search box. I assume most people will use a shortcut.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Priority: -- → P2
Attached patch dbg-find.patch (obsolete) — — Splinter Review 

        Attachment #8335236 -
        Flags: review?(anton)

    
    

    
  
Comment on attachment 8335236 [details] [diff] [review]
dbg-find.patch

Review of attachment 8335236 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/sourceeditor/editor.js
@@ +689,5 @@
>   */
> +Editor.accel = function (key, modifiers={}) {
> +  return (modifiers.shift ? "Shift-" : "") +
> +         (Services.appinfo.OS == "Darwin" ? "Cmd-" : "Ctrl-");
> +         (modifiers.alt ? "Alt-" : "") + key;

This line is unreachable.

        Attachment #8335236 -
        Flags: review?(anton)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        dbg-find.patch
        — 
          — Splinter Review
      

    


  
Dumb typo. Try again.

        Attachment #8335236 -
        Attachment is obsolete: true

        Attachment #8335492 -
        Flags: review?(anton)

        Attachment #8335492 -
        Flags: review?(anton) → review+

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/9057db922227
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28

    
    

    
  
Comment on attachment 8335492 [details] [diff] [review]
dbg-find.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 919709
User impact if declined: Users won't be able to use the "find in all files" functionality in the debugger; it's important
Testing completed (on m-c, etc.): fx-team, m-c
Risk to taking this patch (and alternatives if risky): No risk
String or IDL/UUID changes made by this patch: None

        Attachment #8335492 -
        Flags: approval-mozilla-aurora?

        Attachment #8335492 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
    

    
  
Thank you!

    
  
Keywords: checkin-needed

    
    

    
  
This doesn't apply cleanly to Aurora. Please post a branch-specific patch for uplift.
Flags: needinfo?(vporof)
Keywords: checkin-needed → branch-patch-needed

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch for aurora
        — 
          — Splinter Review
      

    


  
Flags: needinfo?(vporof)

    
  
Keywords: checkin-needed

    
  
Keywords: branch-patch-needed

    
    

    
  
Victor, does this have or need tests?
Flags: needinfo?(vporof)
Flags: in-testsuite?
Whiteboard: verifyme

    
    

    
  
Same answer as in bug 932305.
Flags: needinfo?(vporof)

    
    

    
  
(In reply to Victor Porof [:vp] from comment #16)
> Same answer as in bug 932305.

Updating this bug to reflect bug 932305 comment 10.
Flags: in-testsuite?
Flags: in-testsuite+
Flags: in-qa-testsuite?(hskupin)
Whiteboard: verifyme → [good first verify]

    
    

    
  
Removing my name from in-qa-testsuite flag for a better query.
Flags: in-qa-testsuite?(hskupin) → in-qa-testsuite?

    
    

    
  
If a shortcut test is still wanted I would suggest that you file a bug in Testing:Firefox UI Tests.
Flags: in-qa-testsuite?

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: