Closed Bug 937554 Opened 6 years ago Closed 6 years ago

[Cost Control] Query for the data of the current *data SIM* accordingly to settings configuration.

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

x86_64
Linux
defect
Not set

Tracking

(blocking-b2g:1.3+)

RESOLVED FIXED
1.3 Sprint 6 - 12/6
blocking-b2g 1.3+

People

(Reporter: salva, Assigned: mai)

References

Details

(Whiteboard: [ucid:, 1.3:p1, ft:comms])

Attachments

(1 file)

Is single SIM scenario, this is the SIM currently inserted.
In a dual SIM scenario, this is the SIM marked in settings.
Assignee: nobody → mri
Target Milestone: --- → 1.3 Sprint 6 - 12/6
triage: remove 1.3+ flag since its a targeted feature
blocking-b2g: 1.3? → ---
Blocks: b2g-dsds-1.4
No longer blocks: b2g-dsds-1.4
It should be 1.4 feature.
Blocks: 938433
No longer blocks: b2g-dsds-1.3
Blocks: b2g-dsds-1.4
No longer blocks: 938433
moving this to 1.3 committed as some work must be done to keep cost control app working as is
Blocks: comms_1.3_committed
No longer blocks: comms_1.3_targeted
blocking-b2g: --- → 1.3+
Whiteboard: [ucid: , FT:comms, 1.3:p1]
Attached file proposal patch v1
Please, could you review my code?
Regards
Attachment #8338494 - Flags: review?(salva)
Comment on attachment 8338494 [details]
proposal patch v1

Hello Mai, can you review the comments on GitHub? Ask for the r? once you finish.
Thank you!
Attachment #8338494 - Flags: review?(salva)
Attachment #8338494 - Flags: review?(salva)
Comment on attachment 8338494 [details]
proposal patch v1

A couple of comments on GitHub. Address them and we are done!
Attachment #8338494 - Flags: review?(salva)
Update whiteboard tag to follow format [ucid:{id}, {release}:p{1,2}, ft:{team-id}]
Whiteboard: [ucid: , FT:comms, 1.3:p1] → [ucid:, 1.3:p1, ft:comms]
Comment on attachment 8338494 [details]
proposal patch v1

Please could you review the code?
Attachment #8338494 - Flags: review?(salva)
Comment on attachment 8338494 [details]
proposal patch v1

All looking perfect, please merge once Travis finishes.

Thank you for the patch, :mai!
Attachment #8338494 - Flags: review?(salva) → review+
Master: 772261a7c0fe7d2a80a4c0ec887d669d90c93db7
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.