937554 - [Cost Control] Query for the data of the current *data SIM* accordingly to settings configuration.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Salvador de la Puente González [:salva]]

Is single SIM scenario, this is the SIM currently inserted.
In a dual SIM scenario, this is the SIM marked in settings.

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

triage: remove 1.3+ flag since its a targeted feature

Comment 2

[Ken Chang[:kenkai]]

It should be 1.4 feature.

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

moving this to 1.3 committed as some work must be done to keep cost control app working as is

Comment 4

[Marina Rodríguez [:mai]]

Attachment: proposal patch v1

Please, could you review my code?
Regards

Comment 5

[Salvador de la Puente González [:salva]]

Comment on attachment 8338494 [details]
proposal patch v1

Hello Mai, can you review the comments on GitHub? Ask for the r? once you finish.
Thank you!

Comment 6

[Salvador de la Puente González [:salva]]

Comment on attachment 8338494 [details]
proposal patch v1

A couple of comments on GitHub. Address them and we are done!

Comment 7

[Jean Gong :jgong]

Update whiteboard tag to follow format [ucid:{id}, {release}:p{1,2}, ft:{team-id}]

Comment 8

[Marina Rodríguez [:mai]]

Comment on attachment 8338494 [details]
proposal patch v1

Please could you review the code?

Comment 9

[Salvador de la Puente González [:salva]]

Comment on attachment 8338494 [details]
proposal patch v1

All looking perfect, please merge once Travis finishes.

Thank you for the patch, :mai!

Comment 10

[Salvador de la Puente González [:salva]]

Master: 772261a7c0fe7d2a80a4c0ec887d669d90c93db7