Closed Bug 937610 Opened 11 years ago Closed 11 years ago

Write browser/keyboard integration test for TBPL

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Other
Gonk (Firefox OS)
defect

Tracking

(b2g-v1.2 fixed)

RESOLVED FIXED
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: zcampbell, Unassigned)

Details

Attachments

(2 files)

We need a test at TBPL level to check that keyboard and browser are happy bedfellows.

It does not matter that this test does not load a page., this is more of an integration test than a Browser test.

STR
1. Do not connect to network
2. Type a string into URL bar using the keyboard
3. Tap Go button
4. Assert the src attribute of the `content` iframe to validate that the string was typed into the browser correctly.

Enable this test for TBPL!
pointer to Github pull request https://github.com/mozilla-b2g/gaia/pull/13627
Attachment #830861 - Flags: review?(zcampbell)
Attachment #830861 - Flags: review?(florin.strugariu)
Attachment #830861 - Flags: review?(andrei.hutusoru)
Can we run this on Travis too?

Should we run this on device?
Flags: needinfo?(zcampbell)
I am not sure; I feel like we should run all the tests as often as we can, but then this coverage is very very similar to existing Travis/Jenkins coverage and is very duplicated.

What do you think?
Flags: needinfo?(zcampbell)
+1 let's leave it as it is TBPL only
Attachment #830861 - Flags: review?(florin.strugariu) → review+
Attachment #830861 - Flags: review?(zcampbell) → review+
I feel like we should comment in the test and in the manifest about the decision we have made for future generations to understand.
+1 to adding the comments, and to not running this test on device
Comment on attachment 830861 [details] [review]
added test for browser/keyboard integration

r- ing this just to prompt Viorela to add the comments as requested in the bug.
Attachment #830861 - Flags: review-
Merged master:
https://github.com/mozilla-b2g/gaia/commit/a3efc73ca7c136d2fe5b829fa7556b89dc150128

This will be useful on b2g26_v1.2 TBPL runs too.
Attachment #830861 - Flags: review?(andrei.hutusoru)
Comment on attachment 832261 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13703

Uplifted to v1.2
Attachment #832261 - Flags: review?(trifandreialin)
Attachment #832261 - Flags: review?(moz.teodosia)
Attachment #832261 - Flags: review?(bob.silverberg)
Landed in v1.2: https://github.com/mozilla-b2g/gaia/commit/c53149c0f1141659f22f96e606b60e1ba72443e7
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attachment #832261 - Flags: review?(trifandreialin)
Attachment #832261 - Flags: review?(moz.teodosia)
Attachment #832261 - Flags: review?(bob.silverberg)
Attachment #832261 - Flags: review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: