Closed Bug 937641 Opened 11 years ago Closed 11 years ago

Move toolbar-related classes to the toolbar package

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 28

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

Attachments

(1 file)

Move toolbar-related classes to the toolbar package (r=sriram)
31.76 KB, patch
sriram
: review+
Details | Diff | Splinter Review 
To keep things nice and tidy. And so we can better define the boundaries of our components.
Attachment #830850 - Flags: review?(sriram)
Attachment #830850 - Flags: review?(sriram) → review+
This is bitrotted on fx-team.

patching file mobile/android/base/moz.build
Hunk #1 FAILED at 78
1 out of 5 hunks FAILED -- saving rejects to file mobile/android/base/moz.build.rej
patching file mobile/android/base/resources/layout-large-v11/browser_toolbar.xml
Hunk #1 FAILED at 0
1 out of 3 hunks FAILED -- saving rejects to file mobile/android/base/resources/layout-large-v11/browser_toolbar.xml.rej
patching file mobile/android/base/resources/layout/browser_toolbar.xml
Hunk #2 succeeded at 162 with fuzz 1 (offset 5 lines).
patching file mobile/android/base/resources/layout/gecko_app.xml
Hunk #1 FAILED at 61
1 out of 1 hunks FAILED -- saving rejects to file mobile/android/base/resources/layout/gecko_app.xml.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh pending-toolbar
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/49c93d558e91
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: