9377 - Crash-Page Source causes Apprunner crashes.

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P2)

Description

[Teruko Kobayashi]

Tested 7-7 Win32, Mac, and Linux build.

Step of reproduce
1. Start Apprunner
   As default, http://www.mozillazin.org/ page is loaded
2. Select menu View|Page Source
   Page Source window is shown up, but it is small.
3. Try to resize to make bigger by using mouse.
Apprunner crashed.

Talkback Incident-----------
Trigger Type:  Program Crash
 Trigger Reason:  Access violation

 Call Stack:    (Signature = MSVCRT.dll + 0x1799 (0x78001799) 63c94ef8)
  MSVCRT.dll + 0x1799 (0x78001799)
  MSVCRT.dll + 0x1465 (0x78001465)
  nsBrowserAppCore::LoadUrl
                                                                         [d:\builds\seamonkey\mozilla\xpfe\AppCores\src\nsBrowserAppCore.cpp,
line 805]
  BrowserAppCoreLoadUrl

[d:\builds\seamonkey\mozilla\xpfe\AppCores\src\nsJSBrowserAppCore.cpp, line 390]
  js_Invoke
                                                                         [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 656]
  js_Interpret
                                                                         [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 2218]
  js_Invoke
                                                                         [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 676]
  js_Interpret
                                                                         [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 2218]
  js_Invoke
                                                                         [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 676]
  js_InternalCall
                                                                         [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 750]
  JS_CallFunctionValue
                                                                         [d:\builds\seamonkey\mozilla\js\src\jsapi.c, line 2645]
  nsJSEventListener::HandleEvent
                                                                         [d:\builds\seamonkey\mozilla\dom\src\events\nsJSEventListener.cpp, line
98]
  nsEventListenerManager::HandleEvent

[d:\builds\seamonkey\mozilla\layout\events\src\nsEventListenerManager.cpp, line 903]
  RDFElementImpl::HandleDOMEvent
                                                                         [d:\builds\seamonkey\mozilla\rdf\content\src\nsRDFElement.cpp, line
2351]
  RDFElementImpl::ExecuteJSCode
                                                                         [d:\builds\seamonkey\mozilla\rdf\content\src\nsRDFElement.cpp, line
2690]
  RDFElementImpl::ExecuteOnChangeHandler
                                                                         [d:\builds\seamonkey\mozilla\rdf\content\src\nsRDFElement.cpp, line
2615]
  RDFElementImpl::SetAttribute
                                                                         [d:\builds\seamonkey\mozilla\rdf\content\src\nsRDFElement.cpp, line
1958]
  RDFXULBuilderImpl::AddAttribute
                                                                         [d:\builds\seamonkey\mozilla\rdf\content\src\nsRDFXULBuilder.cpp, line
2874]
  RDFXULBuilderImpl::OnChange
                                                                         [d:\builds\seamonkey\mozilla\rdf\content\src\nsRDFXULBuilder.cpp, line
1329]
  CompositeDataSourceImpl::OnChange
                                                                         [d:\builds\seamonkey\mozilla\rdf\base\src\nsCompositeDataSource.cpp,
line 1411]
  InMemoryDataSource::Change
                                                                         [d:\builds\seamonkey\mozilla\rdf\base\src\nsInMemoryDataSource.cpp,
line 1241]
  CompositeDataSourceImpl::Change
                                                                         [d:\builds\seamonkey\mozilla\rdf\base\src\nsCompositeDataSource.cpp,
line 947]
  RDFXULBuilderImpl::OnSetAttribute
                                                                         [d:\builds\seamonkey\mozilla\rdf\content\src\nsRDFXULBuilder.cpp, line
1782]
  XULDocumentImpl::OnSetAttribute
                                                                         [d:\builds\seamonkey\mozilla\rdf\content\src\nsXULDocument.cpp, line
3734]
  RDFElementImpl::SetAttribute
                                                                         [d:\builds\seamonkey\mozilla\rdf\content\src\nsRDFElement.cpp, line
916]
  setAttribute
                                                                         [d:\builds\seamonkey\mozilla\xpfe\AppCores\src\nsToolkitCore.cpp, line
278]
  nsArgCallbacks::ConstructBeforeJavaScript
                                                                         [d:\builds\seamonkey\mozilla\xpfe\AppCores\src\nsToolkitCore.cpp, line
300]
  nsappshell.dll + 0x49a2 (0x608249a2)

  nsappshell.dll + 0x453f (0x6082453f)

  nsWebShell::OnEndDocumentLoad
                                                                         [d:\builds\seamonkey\mozilla\webshell\src\nsWebShell.cpp, line 3005]
  nsDocLoaderImpl::FireOnEndDocumentLoad
                                                                         [d:\builds\seamonkey\mozilla\webshell\src\nsDocLoader.cpp, line 1035]
  nsDocLoaderImpl::LoadURLComplete
                                                                         [d:\builds\seamonkey\mozilla\webshell\src\nsDocLoader.cpp, line 1306]
  nsDocumentBindInfo::OnStopRequest
                                                                         [d:\builds\seamonkey\mozilla\webshell\src\nsDocLoader.cpp, line 2033]
  OnStopRequestProxyEvent::HandleEvent
                                                                         [d:\builds\seamonkey\mozilla\network\module\nsNetThread.cpp, line 594]
  StreamListenerProxyEvent::HandlePLEvent
                                                                         [d:\builds\seamonkey\mozilla\network\module\nsNetThread.cpp, line 474]
  PL_HandleEvent
                                                                         [plevent.c, line 494]
  PL_ProcessPendingEvents
                                                                         [plevent.c, line 455]
  _md_EventReceiverProc
                                                                         [plevent.c, line 916]
  USER32.dll + 0x1777 (0x77e41777)
  nsappshell.dll + 0x1864 (0x60821864)
  apprunner.exe + 0x23a9 (0x004023a9)
  KERNEL32.dll + 0x1bd3f (0x77eebd3f)

Comment 1

[David Hyatt]

I can't reproduce the crash.  It comes up ok (albeit small).  Handing this one
off to law, who can tweak the window to add some width and height attributes to
the <window> tag to make it come up bigger.

Comment 2

[Bill Law]

No crash, as Dave says.  I fixed the sizing (basically, updated the
viewSource.xul to match reality; I think people make changes to navigator.xul
and forget about this one, which often requires similar tweaks).

I will seek approval and check this in asap.

Here's the diff:

Index: viewSource.xul
===================================================================
RCS file: /cvsroot/mozilla/xpfe/browser/src/viewSource.xul,v
retrieving revision 1.8
diff -r1.8 viewSource.xul
7a8,10
> <!ENTITY mainWindow.titlemodifier "Mozilla">
> <!ENTITY mainWindow.titlemodifierseperator " - ">
> <!ENTITY mainWindow.preface "Source for">
109,109c112,114
<         title="Mozilla">
---
>         title="&mainWindow.title;" titlemodifier="&mainWindow.titlemodifier;"
>         titleseperator ="&mainWindow.titlemodifierseperator;"
windowtype="navigator:viewsource"
>               align="vertical" width="640" height="480">
257,258d261
<   <box id="outer-box" align="vertical">
<
260d262
<
284d285
<   </box>

Comment 3

[Teruko Kobayashi]

I verified this in 7-12 Win32, Mac, and Linux builds.