Closed
Bug 937753
Opened 12 years ago
Closed 12 years ago
Add Popcorn / Thimble / Goggles logo icons to "Make" submenu
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Jacob, Assigned: maronin)
References
()
Details
Attachments
(1 file)
I think it would be a good idea to add small icons of each tool's logo next to the "Multimedia with Popcorn" "Webpages with Thimble "Remixes with X-Ray Goggles"
links in the Submenu under "Make"
This would make the links a little more noticeable (they are quite hidden) and better communicate that there are 3 different tools that we offer
What do you think Kate?
Flags: needinfo?(kate)
Comment 1•12 years ago
|
||
Hi,
If no one is working on this assign this to me.
Thanks,
Zak
Comment 2•12 years ago
|
||
Done! Go for it Zak. Kate can review.
Assignee: nobody → zak.hassan1010
Status: NEW → ASSIGNED
Flags: needinfo?(kate)
Updated•12 years ago
|
Assignee: zak.hassan1010 → nobody
Comment 3•12 years ago
|
||
:k88hudson - do we have any smaller webmaker logos laying around that we could use for this purpose?
Flags: needinfo?(kate)
| Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Jon Buckley [:jbuck] from comment #3)
> :k88hudson - do we have any smaller webmaker logos laying around that we
> could use for this purpose?
I can make them from scratch, and we can use them. I can make a few variations of them and post here if anyone is interested.
| Assignee | ||
Comment 5•12 years ago
|
||
If no one is doing this, I can try and do this issue. I think icons would be greate. Visual feedback is always good.
Comment 6•12 years ago
|
||
It might be possible to just resize the existing logos located on https://webmaker.org/tools/ . But yes, go for it!
Assignee: nobody → steroidcat
Flags: needinfo?(kate)
| Assignee | ||
Comment 7•12 years ago
|
||
I'm not sure where to start for putting the icons (which file should I be working on). I found out that it's not just simple HTML code for that navigation bar and that it's using some sort of templating. Anyone care to give a hint?
| Assignee | ||
Comment 8•12 years ago
|
||
Attachment #8350968 -
Flags: review?(kate)
Comment 9•12 years ago
|
||
What I think would be great to do and also will make the speed of loading the page much better is to make these three icons as CSS image sprites.
| Assignee | ||
Comment 10•12 years ago
|
||
(In reply to Ali Al Dallal [:aali] from comment #9)
> What I think would be great to do and also will make the speed of loading
> the page much better is to make these three icons as CSS image sprites.
Updated as per request ;)
Details in the Pull Request.
Comment 11•12 years ago
|
||
Comment on attachment 8350968 [details] [review]
Pull request for icons issue
This is R+, I will update the image to be compatible with retina though
Attachment #8350968 -
Flags: review?(kate) → review+
Comment 12•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker.org
https://github.com/mozilla/webmaker.org/commit/2292c739924851641932d3fe6669e5159596c050
Bug 937753 - Updated icons for retina
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•