937764 - Clicking Edit review as an admin loads the 'Write a review' form

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Log in as an admin
2. Load https://marketplace-dev.allizom.org/app/pasjanssolitaire/ratings
3. Click on 'Edit' for one of the listed reviews (not written by you)


expected behavior:
https://marketplace-dev.allizom.org/app/pasjanssolitaire/ratings/edit loads

observed behavior:
https://marketplace-dev.allizom.org/app/pasjanssolitaire/ratings/add loads incorrectly

Comment 1

[Matt Basta [:basta]]

This fixes it:

https://github.com/mozilla/fireplace/commit/cc8a3979a6341e8d48f6acb24b6aa1c40ddc043c

However, the ratings API is broken for admins. I filed bug 938415 to track that. Until then, you should be able to get to the edit rating page, you'll just get an error when you try to submit changes.

Comment 2

[Victor Carciu]

The bug described in the initial scenario is fixed, but another problem is now reproducible.

From edit review form, click the backspace button in order to go back to reviews list and you will notice that the Write a review form is displayed instead of reviews list.

Please see screencast : http://screencast.com/t/ObnblXQK

Comment 3

[Matt Basta [:basta]]

https://github.com/mozilla/fireplace/commit/1e7f43c75d4ddb0c782de4c93ca91e951d3e3dba

Good catch! This was a sneaky one.

Comment 4

[Victor Carciu]

Verified as fixed : http://screencast.com/t/xMTh9qJHI5I