937806 - [B2G][Gallery] The Cancel or Save button can be pressed when attempting to grab upper corner crop handles in Edit Mode

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Matthew Vaughan]

Attachment: Video of user attempting to grab crop handles, but pressing the Cancel/Save button.

Description:
When a user attempts to grab the upper corner crop handles, they can inadvertently tap the Cancel or Save button even though the user's finger isn't on the button at all. It seems that the buttons are larger than they appear, i.e. their borders/tap areas are extended out further than expected.

Prerequisites:
Have at least one image on the test device.

Repro Steps:
1) Update Buri to v1.2 COM RIL BuildID: 20131112004004
2) Launch the Gallery app
3) Select an image
4) Tap the Edit Mode button (square with a pencil over it)
5) Tap the Crop button
6) Attempt to grab either of the upper corner crop handles

Actual:
The Cancel or Save button is pressed instead of the crop handle being grabbed.

Expected:
The crop handle is grabbed and the user can adjust the crop area.

Environmental Variables:
Device: Buri v1.2 COM RIL
BuildID: 20131112004004
Gaia: 35b1c6b669b7bf08126df451221113e72642abca
Gecko: 566e850868c7
Version: 26.0
RIL Version: 01.02.00.019.106

Notes:
Repro frequency: 5/5
See attached: TapButtons.3gp

Comment 1

[Jason Smith [:jsmith]]

Does this reproduce on 1.1?

Comment 2

[Matthew Vaughan]

This issue does NOT reproduce on the 11/12/2013 1.1 build. The upper corner crop handles are very easy to grab and the buttons do not appear to be tapped until the user's finger is at least halfway onto the button.

Environmental Variables:
Device: Leo v1.1 COM RIL
BuildID: 20131112041200
Gaia: d9c6b0c3384625e467f892c9dafbc40cfe132180
Gecko: 31fa87bfba88
Version: 18.0
RIL Version: 01.01.00.019.281

Comment 3

[Jason Smith [:jsmith]]

John - Isn't the root problem here the same as bug 935072?

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Jason,

I feel this issue is more complex than bug 935072. It may related to the touch screen. I had suffered the same issue in ZTE Open, but not in Inari and Helix. It's pretty easy to touch the cancel and save while tapping the top corner handles.

I suggest to test the same issue on multiple device to check if this is device dependent issue.

Comment 5

[Jason Smith [:jsmith]]

Can we test this across multiple 1.2 devices to see if this is device dependent or not?

Comment 6

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #5)
> Can we test this across multiple 1.2 devices to see if this is device
> dependent or not?

Another thing to check is to see if this reproduces on a 1.1 Buri device as well.

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

Forgot one thing. I had checked the button size and header size of 1.2, master, and 1.1. The header and save button is no difference on width and height. But the cancel button is more larger on width.

Comment 8

[John Hu [:johnhu][:johu][:醬糊小弟]]

I think I am wrong with comment 4. I can reproduce it with latest 1.2 image in Helix. I touch on the edge of text "Edit" which causes the pressing css feedback of Cancel button.

Comment 9

[Matthew Vaughan]

This issue reproduces on the Helix, Inari, and Leo 1.2 builds. The Cancel and Save buttons can be easily pressed, without even looking like the user touches them, when attempting to grab the upper corner crop handles.

- Helix -
Environmental Variables:
Device: Helix v1.2 COM RIL
BuildID: 20131120004000
Gaia: 5ec2963fff60492c840707df8d8090f9908a5251
Gecko: 2d454e0de2ed
Version: 26.0
RIL Version: 01.02.00.019.102

- Inari -
Environmental Variables:
Device: Inari v1.2 MOZ RIL
BuildID: 20131121004002
Gaia: ce276842c9ac1746073271fb736dfdb626a89240
Gecko: 36c4c667b9f2
Version: 26.0

- Leo -
Environmental Variables:
Device: Leo v1.2 COM RIL
BuildID: 20131120004000
Gaia: 5ec2963fff60492c840707df8d8090f9908a5251
Gecko: 2d454e0de2ed
Version: 26.0
RIL Version: 01.02.00.019.102

Comment 10

[Jason Smith [:jsmith]]

From what I see in the video, this is a minor bug. Not a blocker.

Comment 11

[Punam Dahiya [:pdahiya]]

Not able to replicate the issue in below environment:

Device: Hamachi
BuildId:20140519040204
OS Version 2.0

Marking the bug resolved. Please reopen the bug if someone can still replicate this issue. Thanks