Closed
Bug 937837
Opened 12 years ago
Closed 12 years ago
Update <title> tag in Thimble project when giving project title in Publish pane
Categories
(Webmaker Graveyard :: Thimble, defect)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: Jacob, Assigned: michiel)
Details
Attachments
(1 file)
When you give your Thimble project a title in the Publish pane, it doesn't update the blue title that's shown above the right side preview window
For example here:
https://jake.makes.org/thimble/this-is-a-title/remix
The blue text above the preview pane should say "This is a title"
But instead it says "Preview for Remix of Remix of TTXMXCPTCY - Teletext Art b..."
-----
I think it's because giving a project a title in the Publishing pane doesn't change the former text in the <title> tag inside Thimble itself.
This patch adds title/dialog synchronisation, and will inject a <title> element if it's missing, or an entire <head> section if there is no header element. Changing the title in the HTML source code will change the title in the (usually hidden) publish dialog, and when the publish dialog is open, changing the title there will change the title in the source code (a change that is visible to the user).
Attachment #8346302 -
Flags: review?(scott)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8346302 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/326
This does work, however, this was a choice that we made, to make name and title different things.
Name is actually the name of the make, while title is the title of the page.
I just want to be sure this is something we all agree on, so should probably ping Kate about this just to be sure. It is likely the choice was a technical one, and now that you have it working, should probably be the ideal solution.
With that out of the way, I noticed if I named my project something that I already had named, it didn't display the warning anymore. Was this working for you?
I wonder if this should only sync name and title up when the publish button is clicked, or a change or blur event on the title input is hit, instead of on keystroke.
Attachment #8346302 -
Flags: review?(scott) → review-
|
||
Comment 3•12 years ago
|
||
What we DIDNT want is for users to get confused when they couldn't save their work.
I disagree with this ticket. If I want to title my html page <title>horses are cool</title>, but save it as "biology lesson 1", I should be able to do that. ie, the title of the published work should be seperate from the process of working on it.
Additionally, we found that tons of users would get thrown an error that they already had a work with that title. In the case of remixes this would be super common, ie, frequent users would often see <title>meme</title>, or another popular templte in the title - we wouldn't want to be throwing more errors than needed.
For that reason, I don't think we should ship this patch.
|
|
Reporter | |
Comment 4•12 years ago
|
||
What Brett says makes sense. Just to clarify something:
I filed this ticket because the blue text area gives you a confusing title that pulled from the <title> tag and often has "remix of a remix of my new project" or something, and doesn't match the actual title of your project.
So maybe there's an easier way to solve for that.
(In reply to Jacob [:Jacob] from comment #0)
> When you give your Thimble project a title in the Publish pane, it doesn't
> update the blue title that's shown above the right side preview window
>
> For example here:
> https://jake.makes.org/thimble/this-is-a-title/remix
>
> The blue text above the preview pane should say "This is a title"
>
> But instead it says "Preview for Remix of Remix of TTXMXCPTCY - Teletext Art
> b..."
jacob, brett, what do you consider "the actual title"? because there's the source code title, and that's the one used for the preview, and is technically correct: the title is not the same as the vanity URL, so perhaps the real problem here is the word "title" in the publish dialog.
alternative suggestion: also list the real (from source) title in the publish dialog as an immutable label, so that you see "page title: <immutable label>" plus "published title: <input field>" where the input field is by default just the page title (like now) and you can change it without changing the source code (like now), with the source code title used in the "preview for ...." blue field (also like now =).
Then the publish dialog can no longer create confusion, and the "why" of the preview field is obvious? Just thinking out loud here.
I'm going to invalidate this ticket based on the fact that "preview of ..." should be for the document's title, not the vanity URL. If we want to make it clearer which is used where, then we should file a new bug for how the publish dialog explains which text-from-where means what. If the dialog currently suggests that the vanity URL is the authoritative document title, that probably needs addressing, rather than changing the "preview for..." string.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → INVALID
|
|
||
Comment 8•12 years ago
|
||
I agree with having both title: and name: in the publish dialog, with one being immutable. We can also change the labels for them, which right now one is title, and the other is name, but I think name and title might be clear enough, especially if one is editable.
Also thinking out loud here.
You need to log in
before you can comment on or make changes to this bug.
Description
•