937858 - GetPaddingRectRelativeToSelf shouldn't name its border-only local var "bp"

Status: RESOLVED FIXED

(Core :: Layout, defect, P4)

Description

[Daniel Holbert [:dholbert]]

It looks like GetPaddingRectRelativeToSelf and GetContentRectRelativeToSelf have a shared history -- in particular, they both have a local variable "nsMargin bp".

However, in GetContentRectRelativeToSelf, the name "bp" makes sense (border/padding):
  nsMargin bp(GetUsedBorderAndPadding());
but in GetPaddingRectRelativeToSelf, it doesn't make sense (it's just border):
  nsMargin bp(GetUsedBorder());

We should rename it from "bp" to "b" or, better, "border".

Comment 1

[Daniel Holbert [:dholbert]]

MXR link: http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsFrame.cpp#979

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix: s/bp/border/

Comment 3

[Mats Palmgren (inactive)]

Comment on attachment 831085 [details] [diff] [review]
fix: s/bp/border/

r=mats

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/232b3e8afcf8

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/232b3e8afcf8