938070 - [B2G] AudioDeviceModuleImpl::CreatePlatformSpecificObjects() returns -1 because ptrAudioDeviceUtility == NULL

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[John Lin [:jhlin][:jolin]]

Attachment: Move creation of ptrAudioDeviceUtility out of '#if !defined(WEBRTC_GONK)'

In the commit for bug 932112, creation of ptrAudioDeviceUtility (http://dxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/modules/audio_device/audio_device_impl.cc#299) will be skipped since WEBRTC_GONK is defined (http://dxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/modules/audio_device/audio_device_impl.cc#284). This breaks the check later (http://dxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/modules/audio_device/audio_device_impl.cc#409). 
Because of it, MediaEngineWebRTC::EnumerateAudioDevices() will fail to get audio device (http://dxr.mozilla.org/mozilla-central/source/content/media/webrtc/MediaEngineWebRTC.cpp#291) for gUM.
Moving the creation of ptrAudioDeviceUtility out of '#if !defined(WEBRTC_GONK)' makes it work again.(See patch in attachment)

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/b2g-inbound/rev/fb9f3b754d03

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fb9f3b754d03

Comment 3

[Jason Smith [:jsmith]]

If I'm reading this correctly, this sounds like this is a regression for gUM audio that will prevent retrieval for the microphone stream. In that case, this sounds like a blocker.