938080 - [hamachi][fugu]Bluetooth still work when turn on airplane mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Xinhe Yan]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.19 (KHTML, like Gecko) Ubuntu/11.04 Chromium/18.0.1025.151 Chrome/18.0.1025.151 Safari/535.19

Steps to reproduce:

1 turn on Bluetooth and turn off Aireplane mode
2 restart phone
3 turn on airplane mode, Bluetooth works   --->KO
4 turn off Bluetooth and then turn on Bluetooth
5 turn off Aireplane mode and then turn on Aireplane mode 
6 Bluetooth is still open   --->KO


Actual results:

Bluetooth still work in some case when turn on airplane mode


Expected results:

Bluetooth should close when turn on airplane mode

Comment 1

[Peipei Cheng (needinfo if you need my action)]

I reproduced this on Hamachi.

Test Build: 20131118004001
gaia: 7a23f8c53ba97da9c63a7275b36d155b4526a639
gecko: 14432474328e7558902329c3fc2a8238c3222a7f

Reproduce Steps:
1. start device
2. Turn on Bluetooth
3. Turn on Airplane mode
   => Bluetooth is off
4. Turn on Bluetooth
   => Airplane mode is on. but Bluetooth works.
5. Turn off Airplane mode
6. Turn on Airplane mode
   => Bluetooth is still on.
   => Expected: Bluetooth should be turned off.

Comment 2

[Gina Yeh [:gyeh] [:ginayeh]]

Let me check! Thanks.

Comment 3

[Gina Yeh [:gyeh] [:ginayeh]]

Hi Arthur, please see my comments below and correct me if I was wrong. Thanks.

(In reply to pcheng from comment #1)
> Reproduce Steps:
> 1. start device
> 2. Turn on Bluetooth
> 3. Turn on Airplane mode
>    => Bluetooth is off
> 4. Turn on Bluetooth
>    => Airplane mode is on. but Bluetooth works.

We expect that Bluetooth should be turned on in this scenario.

> 5. Turn off Airplane mode
> 6. Turn on Airplane mode
>    => Bluetooth is still on.
>    => Expected: Bluetooth should be turned off.

Bluetooth should be turned off but it isn't. I can also reproduce this issue. Arthur, can you help to check it?

Comment 4

[Gina Yeh [:gyeh] [:ginayeh]]

Forgot to mention that we didn't turn Bluetooth off at step 6, so Bluetooth can still work.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

The result of step 4 is expected. As for step 6, bluetooth should be turned off.

Comment 6

[Gina Yeh [:gyeh] [:ginayeh]]

Hi Xinhe,

I had no luck to reproduce this issue.

(In reply to Xinhe Yan from comment #0)
> Steps to reproduce:
> 
> 1 turn on Bluetooth and turn off Aireplane mode
> 2 restart phone
> 3 turn on airplane mode, Bluetooth works   --->KO

When I turned on airplane mode, Blueototh is turned off automatically.


> Actual results:
> Bluetooth still work in some case when turn on airplane mode

Did I miss any step? Is there any other STR you can provide?

Comment 7

[Peipei Cheng (needinfo if you need my action)]

Attachment: adblogcat_V1.2.log

I reproduced this with Hamachi V1.2 build
Gaia:     9439907a255e04de4c33493fe03d6670c8256e2f                           
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/fe2a7f0db27b  
BuildID   20131119004006                                                      
Version   26.0  

But I didn't restart phone. Could you please try following steps:
1. Turn on Bluetooth
2. Turn on Airplane mode
3. Turn on Bluetooth
4. Turn off Airplane mode
5. Turn on Airplane mode
   => Bluetooth is still on.
   => Expected: Bluetooth should be turned off.


Attached is the adblogcat. 
Timestamp is 11-20 18:45:08.199

Comment 8

[Peipei Cheng (needinfo if you need my action)]

(In reply to pcheng from comment #7)
> Created attachment 8335208 [details]
> adblogcat_V1.2.log
> 
> I reproduced this with Hamachi V1.2 build
> Gaia:     9439907a255e04de4c33493fe03d6670c8256e2f                           
> Gecko:    http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/fe2a7f0db27b
> 
> BuildID   20131119004006                                                    
> 
> Version   26.0  
> 
> But I didn't restart phone. Could you please try following steps:
> 1. Turn on Bluetooth
> 2. Turn on Airplane mode
> 3. Turn on Bluetooth
> 4. Turn off Airplane mode
> 5. Turn on Airplane mode
>    => Bluetooth is still on.
>    => Expected: Bluetooth should be turned off.
> 
> 
> Attached is the adblogcat. 
> Timestamp is 11-20 18:45:08.199

(In reply to Gina Yeh [:gyeh] [:ginayeh] from comment #6)


Please ignore comment 7

> Hi Xinhe,
> 
> I had no luck to reproduce this issue.
> 
> (In reply to Xinhe Yan from comment #0)
> > Steps to reproduce:
> > 
> > 1 turn on Bluetooth and turn off Aireplane mode
> > 2 restart phone
> > 3 turn on airplane mode, Bluetooth works   --->KO
> 
> When I turned on airplane mode, Blueototh is turned off automatically.
> 
> 
> > Actual results:
> > Bluetooth still work in some case when turn on airplane mode
> 
> Did I miss any step? Is there any other STR you can provide?
After the bug in step 6 is reproduced, restart phone, I saw this issue

Comment 9

[Xinhe Yan]

(In reply to Gina Yeh [:gyeh] [:ginayeh] from comment #6)
As pchen said in comment 8, After the bug in step 6 is reproduced, restart phone,open airplane mode, then you can saw bluetooth is still work

1

Comment 10

[Xinhe Yan]

Make sure Bluetooth and Aireplane mode all turn off
1 turn on Aireplane mode and turn on Bluetooth
2 turn off Aireplane mode
3 restart phone
4 turn on airplane mode and Bluetooth still work

Comment 11

[Preeti Raghunath(:Preeti)]

QA,

Please check if this is a regression issue. Would be nice to also have the regression window.

Comment 12

[sarsenyev]

The issue reproduces on 1.1, 1.2, 1.3 builds
To reproduce the issue on 1.2 follow the steps from the comment 10
But to be able to reproduce it on 1.1 and 1.3 additional steps are required
 
Make sure Bluetooth and Airplane mode are turned off
1 turn on "Airplane mode" and turn on "Bluetooth"
2 turn off "Airplane" mode
3 restart the device
4 turn on "Airplane" mode 
5 Manually turn on "Bluetooth"
6 Toggle "Airplane" mode on/off

Reproducible rate 100%

Actual result:
After restarting the device and manually turning on the "Bluetooth" and then toggling the "airplane" mode on/off, 
the "Bluetooth" is shown active in airplane mode all the time

1.2
Device: Buri 1.2
BuildID: 20131120004000
Gaia: 5ec2963fff60492c840707df8d8090f9908a5251
Gecko: 2d454e0de2ed
Version: 26.0
Firmware revision: V1.2_US_20131115

1.3
Device: Buri 1.3 Central
BuildID: 20131120040202
Gaia: c26480b22ce28c812c347290dd4bad090d83db6f
Gecko: 4f993fa378eb
Version: 28.0a1
Firmware revision: US_20131104

1.1
Device: Leo 1.1 MOZ RIL
BuildID: 20131119041201
Gaia: b585b32441fafa67f2b4582db23be5f3a2afab21
Gecko: 7c3cfc0936ca
Version: 18.0
Firmware version: V10c

Comment 13

[Jason Smith [:jsmith]]

Not a regression, which makes this a non-blocker.

Comment 14

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: pull request

Hi Arthur, 

I am not sure if this patch is good enough, please help to give some feedback.

I add five setting observers in airplane_mode.js of system apps to observe if user toggle something on manually, and set the corresponding 'suspended' state to false.

I also remove the 'suspended' state guard in wifi.js of settings app, since airplane_mode.js of system app take care of that.

Comment 15

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8341564 [details] [review]
pull request

Hi Evelyn,
Please kindly help to review the patch. Thanks

Comment 16

[Steven Yang [:styang]]

After discussed with our partner, it will not block fugu.

Comment 17

[Evelyn Hung]

Comment on attachment 8341564 [details] [review]
pull request

Since Arthur and EJ are working on cleaning up airplane mode, I will let them review this patch to align their plan.

Comment 18

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8341564 [details] [review]
pull request

Sorry for the late reply, Tzu-Lin.

Can you try to rebase and apply your changes based on newest airplane mode design ? If you need help, don't be hesitated to tell me !

Big thanks :)

Comment 19

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8341564 [details] [review]
pull request

Please consolidate the initialization of the settings object. Thanks.

Comment 20

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8341564 [details] [review]
pull request

Hi Arthur,

Please kindly help to review the patch, thanks


Hi EJ,

Since I modify the code related to airplane mode, please kindly give me some feedback. Thanks

Comment 21

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8341564 [details] [review]
pull request

It works well! Just leave the reviewing process to Arthur :) 

Thanks !

Comment 22

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8341564 [details] [review]
pull request

Please check my github comments, thanks!

Comment 23

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8341564 [details] [review]
pull request

Hi Arthur,

I've addressed your comments. Please help to review it again, Thanks

Comment 24

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8341564 [details] [review]
pull request

Feedback+ as I'm not a peer of the system app.

Comment 25

[Arthur Chen [:arthurcc][inactive after 6/30]]

Nominate for 1.3+ as it blocks a 1.3 blocker.

Comment 26

[Jason Smith [:jsmith]]

(In reply to Arthur Chen [:arthurcc] (OOO 1/30 ~ 2/4) from comment #25)
> Nominate for 1.3+ as it blocks a 1.3 blocker.

I don't think this is right bug to take here - that bug points to a regression, where as this bug is not. Clearing flags.

Comment 27

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Triage: Please read bug 960706 comment 24 and respect the estimation of engineers who work on this bug.

Comment 28

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Actually, if we could make people feel better by dup this bug to bug 960706 and submit a patch there, please do, since according to bug 960706 comment 22 we fix that bug with the patch here.

I really don't want to spend time arguing on Bugzilla bureaucracy.

Comment 29

[Jason Smith [:jsmith]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #28)
> Actually, if we could make people feel better by dup this bug to bug 960706
> and submit a patch there, please do, since according to bug 960706 comment
> 22 we fix that bug with the patch here.
> 
> I really don't want to spend time arguing on Bugzilla bureaucracy.

Nah, don't worry about it. I'll just + this here.

Comment 30

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Jason Smith [:jsmith] from comment #29)
> Nah, don't worry about it. I'll just + this here.

Thank you very much.

Comment 32

[Arthur Chen [:arthurcc][inactive after 6/30]]

Note that please also ensure the issue reported in bug 960706 gets fixed with the patch.

Comment 33

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8341564 [details] [review]
pull request

Hi Arthur,
I added unit tests for the patch. Please kindly help to review it, thanks.

Comment 34

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8341564 [details] [review]
pull request

r=me. Thank you for the effort!

Comment 35

[Tzu-Lin Huang [:dwi2][:tzhuang]]

travis is green now
https://travis-ci.org/mozilla-b2g/gaia/builds/18329046

landed on master
https://github.com/mozilla-b2g/gaia/commit/7689a80de843f12ad99b0fd6c19cb7040aba0634

Comment 36

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 7689a80de843f12ad99b0fd6c19cb7040aba0634 to:
v1.3: 2688798a90a19d8869631e78e82f160005cd4545