938162 - Stray non-js test sections in various browser.ini files

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[:Gijs (he/him)]

Non-exhaustive search:

[browser_registerProtocolHandler_notification.html]
[browser_tab_dragdrop2_frame1.xul]


These should be listed as support files, not as tests.

There may be others elsewhere in the tree. Should probably just grep and fix all of them.

Comment 1

[:Gijs (he/him)]

gkruitbosch-16516:mozilla-central gkruitbosch$ find . -iname 'browser.ini' | xargs grep '\[.*\]' | grep -v 'DEFAULT' | grep -v 'js\]'
./browser/base/content/test/general/browser.ini:[browser_bug479408_sample.html]
./browser/base/content/test/general/browser.ini:[browser_bug678392-1.html]
./browser/base/content/test/general/browser.ini:[browser_bug678392-2.html]
./browser/base/content/test/general/browser.ini:[browser_clearplugindata.html]
./browser/base/content/test/general/browser.ini:[browser_clearplugindata_noage.html]
./browser/base/content/test/general/browser.ini:[browser_tab_dragdrop2_frame1.xul]
./browser/base/content/test/general/browser.ini:[browser_registerProtocolHandler_notification.html]
./browser/components/privatebrowsing/test/browser/browser.ini:[browser_privatebrowsing_concurrent_page.html]
./browser/components/privatebrowsing/test/browser/browser.ini:[browser_privatebrowsing_cookieacceptdialog.html]
./browser/components/privatebrowsing/test/browser/browser.ini:[browser_privatebrowsing_geoprompt_page.html]
./browser/components/privatebrowsing/test/browser/browser.ini:[browser_privatebrowsing_localStorage_before_after_page.html]
./browser/components/privatebrowsing/test/browser/browser.ini:[browser_privatebrowsing_localStorage_before_after_page2.html]
./browser/components/privatebrowsing/test/browser/browser.ini:[browser_privatebrowsing_localStorage_page1.html]
./browser/components/privatebrowsing/test/browser/browser.ini:[browser_privatebrowsing_localStorage_page2.html]
./browser/components/privatebrowsing/test/browser/browser.ini:[browser_privatebrowsing_placesTitleNoUpdate.html]
./browser/components/privatebrowsing/test/browser/browser.ini:[browser_privatebrowsing_protocolhandler_page.html]
./browser/components/privatebrowsing/test/browser/browser.ini:[browser_privatebrowsing_windowtitle_page.html]
./browser/devtools/fontinspector/test/browser.ini:[browser_font.woff]
./browser/devtools/fontinspector/test/browser.ini:[browser_fontinspector.html]
./browser/devtools/framework/test/browser.ini:[browser_toolbox_options_disablejs.html]
./browser/devtools/framework/test/browser.ini:[browser_toolbox_options_disablejs_iframe.html]
./browser/devtools/inspector/test/browser.ini:[browser_inspector_breadcrumbs.html]
./browser/devtools/inspector/test/browser.ini:[browser_inspector_bug_650804_search.html]
./browser/devtools/inspector/test/browser.ini:[browser_inspector_bug_831693_search_suggestions.html]
./browser/devtools/inspector/test/browser.ini:[browser_inspector_cmd_inspect.html]
./browser/devtools/inspector/test/browser.ini:[browser_inspector_dead_node_exception.html]
./browser/devtools/inspector/test/browser.ini:[browser_inspector_destroyselection.html]
./browser/devtools/inspector/test/browser.ini:[browser_inspector_menu.html]
./browser/devtools/inspector/test/browser.ini:[browser_inspector_select_last_selected.html]
./browser/devtools/inspector/test/browser.ini:[browser_inspector_select_last_selected2.html]
./browser/devtools/inspector/test/browser.ini:[browser_inspector_bug_848731_reset_selection_on_delete.html]
./browser/devtools/markupview/test/browser.ini:[browser_inspector_markup_edit.html]
./browser/devtools/markupview/test/browser.ini:[browser_inspector_markup_mutation.html]
./browser/devtools/markupview/test/browser.ini:[browser_inspector_markup_mutation_flashing.html]
./browser/devtools/markupview/test/browser.ini:[browser_inspector_markup_navigation.html]
./browser/devtools/markupview/test/browser.ini:[browser_inspector_markup_subset.html]
./browser/devtools/markupview/test/browser.ini:[browser_inspector_markup_765105_tooltip.png]
./browser/devtools/shared/test/browser.ini:[browser_layoutHelpers.html]
./browser/devtools/shared/test/browser.ini:[browser_layoutHelpers_iframe.html]
./browser/devtools/shared/test/browser.ini:[browser_templater_basic.html]
./browser/devtools/shared/test/browser.ini:[browser_toolbar_basic.html]
./browser/devtools/shared/test/browser.ini:[browser_toolbar_webconsole_errors_count.html]
./browser/devtools/styleeditor/test/browser.ini:[browser_styleeditor_cmd_edit.html]
./dom/tests/browser/browser.ini:[browser_frame_elements.html]
./dom/tests/browser/browser.ini:[browser_geolocation_privatebrowsing_page.html]
./toolkit/forgetaboutsite/test/browser/browser.ini:[browser_clearplugindata.html]

Comment 2

[:Gijs (he/him)]

Attachment: if it looks, swims and quacks like a duck, but doesn't end in .js, let's not call it a test,

https://tbpl.mozilla.org/?tree=Try&rev=582873be95eb

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 831569 [details] [diff] [review]
if it looks, swims and quacks like a duck, but doesn't end in .js, let's not call it a test,

Review of attachment 831569 [details] [diff] [review]:
-----------------------------------------------------------------

You don't need a build peer review for changes like this. I'm happy to review it as a member of fx-team though :)

Comment 4

[:Gijs (he/him)]

Attachment: if it looks, swims and quacks like a duck, but doesn't end in .js, let's not call it a test,

Unbitrotted against fx-team. That try run had a surprising amount of orange, but maybe it was just bad luck? Retriggered some, will look again in the morning. Maybe I messed up somewhere...

Comment 5

[Phil Ringnalda (:philor)]

If things are surprisingly bad on Try, it's always a good idea to start by blaming your parent. In this case, your parent caused us to close every trunk tree for three days, mostly because of browser-chrome, so I'm not surprised to see browser-chrome orange.

Comment 6

[:Gijs (he/him)]

(In reply to Phil Ringnalda (:philor) from comment #5)
> If things are surprisingly bad on Try, it's always a good idea to start by
> blaming your parent. In this case, your parent caused us to close every
> trunk tree for three days, mostly because of browser-chrome, so I'm not
> surprised to see browser-chrome orange.

Alright. The Windows and Mac orange somewhat cleared up on retriggers anyway, so combined with this comment and my incredulity about having actually broken anything with this change, I decided to land:

https://hg.mozilla.org/integration/fx-team/rev/3461b572a2db

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3461b572a2db