938184 - Users should not create, join, or leave groups from the profile create/edit screens

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

When the curated groups feature lands, we will have a new way to create groups: It will be a big button on the group listing screen that says, "Create Group". Every new group will have a curator. 

This is a departure from groups as they've existed to date. And that's OK. We have several bugs whose genesis is in this "anyone can create numerous groups just by typing something into their profile" [0]. So we're going to change that. 

When curated groups lands, it should include the code that autocompletes groups in the profile edit screen. But it should NOT include the code currently present that creates groups from strings typed into the groups field in profile edit screens. 

All future groups will be created with the "Create Group" button. All future groups will have a curator.

[0] Bug 700718

Comment 1

[Dan Poirier [:dpoirier]]

What about skills and languages?

(It'd be simplest to change all of these at the same time.)

Comment 2

[Justin Crawford [:hoosteeno] [:jcrawford]]

(In reply to Dan Poirier [:dpoirier] from comment #1)
> What about skills and languages?

WRT languages, we're replacing the entire field with a dropdown (rather, multiple dropdowns) in bug 926687. People will not be able to create languages. If that work ties into this work, great!

WRT skills, I think people should be able to create skills arbitrarily. We haven't thought of them all yet. :)

Justin

Comment 3

[Dan Poirier [:dpoirier]]

Pull request: https://github.com/mozilla/mozillians/pull/729

Comment 4

[Andrei Hajdukewycz [:sancus]]

https://github.com/mozilla/mozillians/commit/ef9d0bdc092b0a443a091e7fe6d817e381ac85b4

Merged into curatedgroups.

Comment 5

[Dan Poirier [:dpoirier]]

:hoosteeno should people even be able to join existing groups from their profile edit page?  Or should they have to go to the group's page and click Join?  Maybe the group isn't accepting members, or requires the curator to accept them.

Comment 6

[Justin Crawford [:hoosteeno] [:jcrawford]]

People should not be able to join existing groups from their profile edit page. The only way to join a group when Curated Groups lands is to visit the group and click join.

Comment 7

[Dan Poirier [:dpoirier]]

What about leaving groups from the profile edit page? Should the groups appear on the profile edit page at all?

Comment 8

[Giorgos Logiotatidis [:giorgos]]

I found the UX to join groups strange, while testing curatedgroups branch. Users can fill in any group name they want while editing their profile and the ones that do not exist will just be ignored, without any messasing.

With the changes in 'curatedgroups' I believe that we can drop group editing from the edit profile page and only have the join buttons on the group pages.

Otherwise we should at least at some messages to notify users that groups are not created this way anymore.

Comment 9

[Justin Crawford [:hoosteeno] [:jcrawford]]

Sorry for the confusion on this. I realize we're conflating two distinct changes in this bug: The ability to *create* groups from the profile edit screen, and the ability to to *join* groups from the profile edit screen. I agree with the most recent comments and suggest we get rid of both. So, some suggested specs:

* The profile and profile edit screens should not provide any facility to create groups
* The profile and profile edit screens should not provide any facility to manage group memberships (no join, no leave, no way to type new group names)
* The profile and profile edit screens should show groups that a user is a member of. The names of the groups should be links to the group screens where a user can join/leave groups. 

williamr, what do you think?

Comment 10

[William Reynolds [:williamr]]

(In reply to Justin Crawford [:hoosteeno] from comment #9)
> Sorry for the confusion on this. I realize we're conflating two distinct
> changes in this bug: The ability to *create* groups from the profile edit
> screen, and the ability to to *join* groups from the profile edit screen. I
> agree with the most recent comments and suggest we get rid of both. So, some
> suggested specs:
> 
> * The profile and profile edit screens should not provide any facility to
> create groups
> * The profile and profile edit screens should not provide any facility to
> manage group memberships (no join, no leave, no way to type new group names)
> * The profile and profile edit screens should show groups that a user is a
> member of. The names of the groups should be links to the group screens
> where a user can join/leave groups. 
> 
> williamr, what do you think?

I agree with this. With the new groups UI, a user will no longer create or edit groups from the profile and profile edit views. Creating a group and managing your membership in a group will happen on the group pages.

Comment 11

[Dan Poirier [:dpoirier]]

New pull request to disable all joining and leaving groups from the profile edit page:
https://github.com/mozilla/mozillians/pull/747

Comment 12

[Dan Poirier [:dpoirier]]

https://github.com/mozilla/mozillians/pull/747 has been merged to the curatedgroups branch.

Comment 13

[Justin Crawford [:hoosteeno] [:jcrawford]]

Resolving this since it's merged.

Comment 14

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/931c45871011ae74e404cef7a9007a12be665ce7
Bug 938184 - Don't allow creating groups while editing user profile

Part of the changes for curated groups is that groups will only be
creatable from the groups list page, so only allow people editing
their profiles to select groups that already exist.

The tag-it library that was being used to implement the groups
selection could not easily be configured or modified to prevent
users from selecting non-existent items, so the groups field
was changed to use django-selectable. Styling was added to make
the django-selectable field look like the current tag-it fields,
which are still being used for e.g. skills and languages.

https://github.com/mozilla/mozillians/commit/ef9d0bdc092b0a443a091e7fe6d817e381ac85b4
merging: Bug 938184 - Don't allow creating groups while editing user profile

Comment 15

[Justin Potts [:justinpotts]]

Attachment: qa - verified on stage

When a user is editing their profile, a user is not able to create a group, matching the request in the description.

Comment 16

[Matt Brandt [:mbrandt]]

Thank you :justinpotts! Bumping to verified per comment 15

Comment 17

[Justin Potts [:justinpotts]]

QA verified on stage

When viewing the homepage regardless of being logged in or not, typing the character 's' selects the search field and allows text input.

Comment 18

[Justin Potts [:justinpotts]]

^Wrong bug. I apologize.