938203 - [meta] [prettify] support pretty printing ES6

Status: RESOLVED WORKSFORME

(DevTools :: General, defect)

Description

[Liu Ping]

In Scratchpad of current Nightly, given following codes,

  foo = (x) => x+1;
  let a = [1,2,3];
  for (x of a) console.log(x);

when "Pretty Print", these codes get wrong results as this:

  foo = (x) = > x + 1;
  leta = [
    1,
    2,
    3
  ];
  for (xofa) console.log(x);

the ArrowExpression "=>" becomes "= >", with a space in the middle.
"let a" becomes "leta", and "(x of a)" becomes "(xofa)".

This means that currently the "Pretty Print" in Scratchpad cannot correctly print chrome://ping/content/xbl/scratchpad.js itself.

Comment 1

[Liu Ping]

(wrong url)
This means that currently the "Pretty Print" in Scratchpad cannot correctly print chrome://browser/content/devtools/scratchpad.js itself.

Comment 2

[Brandon Benvie [:benvie]]

We recently switched to using acorn [1] for our parser, which only supports ES5. We hope to either add ES6 support or that the author will add ES6 support in the future, but there's a lot of new syntax in ES6.

Comment 5

[Ingvar Stepanyan (RReverser)]

Acorn ES6 support is coming in https://github.com/marijnh/acorn/pull/110.

Comment 6

[Phil Keeling]

Acorn now supports ES6. This should be fixable.

Comment 7

[maxm]

Problem still exist. Same issue with "Pretty Print" scratchpad in FF57.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

I think we handled the cases that were problematic and it doesn't make sense to keep this meta around as we have Bug 1070862