Write test to enable Power Save mode

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
P4
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: zac, Assigned: AlinT)

Tracking

unspecified
Other
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-v1.2 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
This test is very similar to test_settings_airplane_mode.py

You will need a device to write this test.

setUp:
Using the APIs, enable data, bluetooth and geolocation

Test case:
1. Navigate to Settings app
2. Enable power save mode
3. Assert that data, bluetooth, geolocation are all disabled

Comment 1

5 years ago
Created attachment 8335407 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13880

Pointer to Github pull-request

Updated

5 years ago
Attachment #8335407 - Flags: review?(zcampbell)
Attachment #8335407 - Flags: review?(trifandreialin)
Attachment #8335407 - Flags: review?(florin.strugariu)
Attachment #8335407 - Flags: review?(bob.silverberg)
Comment on attachment 8335407 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13880

The test doesn't pass and it isn't checking the correct things. See the PR for details.
Attachment #8335407 - Flags: review?(bob.silverberg) → review-
Attachment #8335407 - Flags: review?(florin.strugariu) → review-

Updated

5 years ago
Attachment #8335407 - Flags: review?
Attachment #8335407 - Flags: review-
Attachment #8335407 - Flags: review? → review+
(Assignee)

Updated

5 years ago
Attachment #8335407 - Flags: review?(trifandreialin) → review+
(Assignee)

Updated

5 years ago
status-b2g-v1.2: --- → affected
(Assignee)

Comment 4

5 years ago
I will uplift it to v1.2, assigning myself
(Assignee)

Updated

5 years ago
Assignee: nobody → trifandreialin
(Reporter)

Comment 5

5 years ago
Reverted this because some nits in the pull weren't addressed:

https://github.com/mozilla-b2g/gaia/commit/62d09fb5fb595c63356e493c192d878fa7128cdc
(Assignee)

Comment 6

5 years ago
Created attachment 8341691 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14312

Pointer to Github pull-request
(Assignee)

Comment 7

5 years ago
Comment on attachment 8341691 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14312

pull request for v1.2
Attachment #8341691 - Flags: review?(viorela.ioia)
Attachment #8341691 - Flags: review?(florin.strugariu)
Attachment #8341691 - Flags: review?(bob.silverberg)
Attachment #8341691 - Flags: review?(andrei.hutusoru)
(Assignee)

Comment 8

5 years ago
Created attachment 8341696 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14313

Pointer to Github pull-request
(Assignee)

Comment 9

5 years ago
Comment on attachment 8341696 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14313

New pull for this test, with comment addressed
Attachment #8341696 - Flags: review?(zcampbell)
Attachment #8341696 - Flags: review?(viorela.ioia)
Attachment #8341696 - Flags: review?(florin.strugariu)
Attachment #8341696 - Flags: review?(bob.silverberg)
Attachment #8341696 - Flags: review?(andrei.hutusoru)
(Assignee)

Updated

5 years ago
Attachment #8335407 - Attachment is obsolete: true
Attachment #8335407 - Flags: review?(zcampbell)
Attachment #8335407 - Flags: review?
Comment on attachment 8341696 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14313

Just a tiny nit in the PR, so this gets my r+.  Just one question though, should we also switch power save off and make sure that everything gets re-enabled?
Attachment #8341696 - Flags: review?(bob.silverberg) → review+
Flags: needinfo?(zcampbell)
Comment on attachment 8341691 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14312

We really shouldn't be submitting PRs for uplifts before the change lands on master. We should wait until there is a commit on master to cherry-pick.
Attachment #8341691 - Flags: review?(bob.silverberg) → review-
Attachment #8341696 - Flags: review?(viorela.ioia) → review+
Comment on attachment 8341696 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14313

Fix the nit and we are good
Attachment #8341696 - Flags: review?(florin.strugariu) → review+
(Assignee)

Comment 13

4 years ago
Comment on attachment 8341691 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14312

nit fixed
Attachment #8341691 - Flags: review- → review?(bob.silverberg)
Comment on attachment 8341691 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14312

Landed on v1.2 in https://github.com/mozilla-b2g/gaia/commit/daa07bf53d8aec315fa8b9f07d356a30c77fb593
Attachment #8341691 - Flags: review?(viorela.ioia)
Attachment #8341691 - Flags: review?(florin.strugariu)
Attachment #8341691 - Flags: review?(bob.silverberg)
Attachment #8341691 - Flags: review?(andrei.hutusoru)
Attachment #8341691 - Flags: review+
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-b2g-v1.2: affected → fixed
Flags: needinfo?(zcampbell)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.