938212 - GenerationalGC: Iterator prototype objects should be tenured

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

Attachment: tenure-protos

The prototype objects defined in GlobalObject::initIteratorClasses() can be accessed by off-main-thread compilation, so they should be tenured.

Comment 1

[Luke Wagner [:luke]]

Comment on attachment 831621 [details] [diff] [review]
tenure-protos

Forwarding review to bhackett who's working more with this.

Comment 2

[Brian Hackett [Laid off!]]

Comment on attachment 831621 [details] [diff] [review]
tenure-protos

Review of attachment 831621 [details] [diff] [review]:
-----------------------------------------------------------------

Can you rename these methods NewSingletonObjectWith{...}Prototype to match their new behavior?

Comment 3

[Jon Coppeard (:jonco)]

(In reply to Brian Hackett (:bhackett) from comment #2)
> Can you rename these methods NewSingletonObjectWith{...}Prototype to match
> their new behavior?

Yes, good idea.

Comment 4

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d655d985076

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0d655d985076