Closed Bug 938212 Opened 6 years ago Closed 6 years ago

GenerationalGC: Iterator prototype objects should be tenured

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: jonco, Assigned: jonco)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Attached patch tenure-protosSplinter Review
The prototype objects defined in GlobalObject::initIteratorClasses() can be accessed by off-main-thread compilation, so they should be tenured.
Attachment #831621 - Flags: review?(luke)
Comment on attachment 831621 [details] [diff] [review]
tenure-protos

Forwarding review to bhackett who's working more with this.
Attachment #831621 - Flags: review?(luke) → review?(bhackett1024)
Comment on attachment 831621 [details] [diff] [review]
tenure-protos

Review of attachment 831621 [details] [diff] [review]:
-----------------------------------------------------------------

Can you rename these methods NewSingletonObjectWith{...}Prototype to match their new behavior?
Attachment #831621 - Flags: review?(bhackett1024) → review+
(In reply to Brian Hackett (:bhackett) from comment #2)
> Can you rename these methods NewSingletonObjectWith{...}Prototype to match
> their new behavior?

Yes, good idea.
https://hg.mozilla.org/mozilla-central/rev/0d655d985076
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.