938216 - middle unsuccessfully tries to raise a timeout with a message

Status: RESOLVED FIXED

(Socorro Graveyard :: Middleware, defect)

Description

[K Lars Lohn [:lars] [:klohn]]

the timeout exception doesn't allow associated messages.  but the middleware tries to do it making the exception fail and the middleware returns the wrong exception to the UI.

fix it.

Comment 1

[K Lars Lohn [:lars] [:klohn]]

here's the error from staging:

[Wed Nov 13 09:31:11 2013] [error] 2013-11-13 09:31:11,598 DEBUG - MainThread - Inserting priority job into RabbitMQ a0a1cd47-d22b-4f68-83e5-338bc2131113
[Wed Nov 13 09:31:11 2013] [error] [client 10.8.81.216] Traceback (most recent call last):
[Wed Nov 13 09:31:11 2013] [error] [client 10.8.81.216]   File "/data/socorro/socorro-virtualenv/lib/python2.6/site-packages/web/application.py", line 237, in process
[Wed Nov 13 09:31:11 2013] [error] [client 10.8.81.216]     return self.handle()
[Wed Nov 13 09:31:11 2013] [error] [client 10.8.81.216]   File "/data/socorro/socorro-virtualenv/lib/python2.6/site-packages/web/application.py", line 228, in handle
[Wed Nov 13 09:31:11 2013] [error] [client 10.8.81.216]     return self._delegate(fn, self.fvars, args)
[Wed Nov 13 09:31:11 2013] [error] [client 10.8.81.216]   File "/data/socorro/socorro-virtualenv/lib/python2.6/site-packages/web/application.py", line 394, in _delegate
[Wed Nov 13 09:31:11 2013] [error] [client 10.8.81.216]     return handle_class(f)
[Wed Nov 13 09:31:11 2013] [error] [client 10.8.81.216]   File "/data/socorro/socorro-virtualenv/lib/python2.6/site-packages/web/application.py", line 385, in handle_class
[Wed Nov 13 09:31:11 2013] [error] [client 10.8.81.216]     return tocall(*args)
[Wed Nov 13 09:31:11 2013] [error] [client 10.8.81.216]   File "/data/socorro/application/socorro/middleware/middleware_app.py", line 493, in GET
[Wed Nov 13 09:31:11 2013] [error] [client 10.8.81.216]     raise Timeout(str(msg))
[Wed Nov 13 09:31:11 2013] [error] [client 10.8.81.216] TypeError: __init__() takes exactly 1 argument (2 given)

Comment 2

[[DEACTIVATED] Adrian Gaudebert]

Pull request: https://github.com/mozilla/socorro/pull/1672

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/fc43c87cb9fb27d5006b1983d78ce10db3a1addd
Fixes bug 938216 - Timeout cannot accept messages.

https://github.com/mozilla/socorro/commit/8735b34b79980dc7e84482054efd64f015357d3f
Merge pull request #1672 from AdrianGaudebert/938216-timeout-middleware

Fixes bug 938216 - Timeout cannot accept messages.