Closed
Bug 93827
Opened 23 years ago
Closed 23 years ago
Print module autoselection could be better...
Categories
(Core :: Printing: Output, enhancement)
Tracking
()
VERIFIED
FIXED
mozilla0.9.4
People
(Reporter: roland.mainz, Assigned: roland.mainz)
Details
(Keywords: crash)
Attachments
(2 files)
15.65 KB,
patch
|
Details | Diff | Splinter Review | |
1.11 KB,
patch
|
Details | Diff | Splinter Review |
Unix print module autoselection could be better. Currently the Xprint module is "activated" by setting the XPSERVERLIST env var; setting |user_pref("print.print_method", 1)| in prefs.js forces Xprint module, setting |user_pref("print.print_method", 0)| forces the PostScript module. It would be better to do it this way: |user_pref("print.print_method", x)| x=0 : default, use autoselection via XPSERVERLIST x=1 : use Xprint module x=2 : use PostScript module x=3 : use Win32 print API ("reserved" value, not implemented on Unix :-) More things to fix: - the code should use |enum|s instead of plain integer values - "print.print_method" should be documented in unix.js - |#ifdef USE_POSTSCRIPT| PostScript glue code to implement RFE/bug 80625 partially...
Assignee | ||
Comment 1•23 years ago
|
||
Reassigning to myself...
Assignee: dcone → Roland.Mainz
Target Milestone: --- → mozilla0.9.4
Assignee | ||
Comment 2•23 years ago
|
||
Assignee | ||
Comment 3•23 years ago
|
||
Filed patch. Note that this patch fixes crashes when the print device context cannot initalize for some reason, too. Requesting r=/sr=
Status: NEW → ASSIGNED
Keywords: crash
Assignee | ||
Updated•23 years ago
|
Comment 4•23 years ago
|
||
looks good, make sure to run through tests for the methods you support. r=dcone.
Assignee | ||
Comment 5•23 years ago
|
||
dcone: > looks good, make sure to run through tests for the methods you support. yup... I tested that... and I'll test that again tonight... > r=dcone. thanks!
Comment 6•23 years ago
|
||
sr=blizzard
fix checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•23 years ago
|
||
Reopening. Unix builds with GTK+ toolkit but without libXp.so do not build (like "worms"). Silly mistake... Patch follows...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 9•23 years ago
|
||
Assignee | ||
Comment 10•23 years ago
|
||
Oh... yes... I forgot to close this one... :-) Fixed. And works... :-) sujay, wanna verify, please ?
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Comment 11•23 years ago
|
||
Roland can you verify this and mark VERIFIED-FIXED ? thanks.
Assignee | ||
Comment 12•23 years ago
|
||
Tested.... works. Marking bug as VERIFIED.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•