Print module autoselection could be better...

VERIFIED FIXED in mozilla0.9.4

Status

()

--
enhancement
VERIFIED FIXED
18 years ago
16 years ago

People

(Reporter: roland.mainz, Assigned: roland.mainz)

Tracking

({crash})

Trunk
mozilla0.9.4
All
Linux
crash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

18 years ago
Unix print module autoselection could be better. 
Currently the Xprint module is "activated" by setting the XPSERVERLIST env var;
setting |user_pref("print.print_method", 1)| in prefs.js forces Xprint module,
setting |user_pref("print.print_method", 0)| forces the PostScript module.

It would be better to do it this way:
|user_pref("print.print_method", x)|
x=0 : default, use autoselection via XPSERVERLIST
x=1 : use Xprint module
x=2 : use PostScript module
x=3 : use Win32 print API ("reserved" value, not implemented on Unix :-)

More things to fix:
- the code should use |enum|s instead of plain integer values
- "print.print_method" should be documented in unix.js
- |#ifdef USE_POSTSCRIPT| PostScript glue code to implement RFE/bug 80625
partially...
(Assignee)

Comment 1

18 years ago
Reassigning to myself...
Assignee: dcone → Roland.Mainz
Target Milestone: --- → mozilla0.9.4
(Assignee)

Comment 2

18 years ago
(Assignee)

Comment 3

18 years ago
Filed patch. Note that this patch fixes crashes when the print device context
cannot initalize for some reason, too.

Requesting r=/sr=
Status: NEW → ASSIGNED
Keywords: crash
(Assignee)

Updated

18 years ago
Keywords: patch, review

Comment 4

18 years ago
looks good, make sure to run through tests for the methods you support.
r=dcone.
(Assignee)

Comment 5

18 years ago
dcone:
> looks good, make sure to run through tests for the methods you support.
yup... I tested that... and I'll test that again tonight...

> r=dcone.

thanks!
sr=blizzard

Comment 7

18 years ago
fix checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

18 years ago
Reopening. 

Unix builds with GTK+ toolkit but without libXp.so do not build (like "worms").
Silly mistake... Patch follows...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 9

18 years ago
Posted patch bustage fixSplinter Review
(Assignee)

Comment 10

18 years ago
Oh... yes... I forgot to close this one... :-)

Fixed. And works... :-)

sujay, wanna verify, please ?
Status: REOPENED → RESOLVED
Last Resolved: 18 years ago18 years ago
Resolution: --- → FIXED

Comment 11

18 years ago
Roland can you verify this and mark VERIFIED-FIXED ? thanks.
(Assignee)

Comment 12

18 years ago
Tested.... works.
Marking bug as VERIFIED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.