Closed
Bug 93834
Opened 24 years ago
Closed 18 years ago
Common source comments spelling mistake - deprecated, not depricated
Categories
(Core Graveyard :: Tracking, defect)
Core Graveyard
Tracking
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 106386
People
(Reporter: neilconway, Assigned: neilconway)
References
()
Details
Attachments
(2 files)
10.92 KB,
patch
|
Details | Diff | Splinter Review | |
8.04 KB,
patch
|
Details | Diff | Splinter Review |
There is a common spelling mistake in the Mozilla source -- 'depricated' is used
instead of 'deprecated'.
Assignee | ||
Comment 1•24 years ago
|
||
Comment 2•24 years ago
|
||
confirming.
Does this patch fix all occurences? If it does - then people might bother to
give it a quick review.
Also, it's convention to attach "diff -u" output,
which is a bit easier for humans to read.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Spelling mistake - deprecated, not depricated → Common source comments spelling mistake - deprecated, not depricated
Assignee | ||
Comment 3•24 years ago
|
||
Assignee | ||
Comment 4•24 years ago
|
||
I attached a new patch in unified diff format.
Yes, this patch does fix all the instances of the bug in the current CVS sources
(I searched using `grep`).
Thanks for the suggestions.
Careless greps yield 11 files (14 changes) in patch.
perhaps 22 (32 occurrences) in the mozilla tree?
warnings: security/nss is locked, js might have special rules.
general thought: when this is checked in, should we post to npm.<somethings>
reminding people to correctly spell this word?
I wonder if we should teach lxr about deprecated :-)
I'd give an r= but i think i'll wait for other comments...
Assignee: scc → neilconway
Component: Browser-General → Tracking
QA Contact: doronr → scc
Assignee | ||
Comment 7•24 years ago
|
||
WRT: additional files: Woops, I must have missed some (does 'make -f client
checkout' not checkout the entire tree?). I'll check that and upload a new patch
when I get a chance (or else someone else can, it's not exactly rocket science
;-) ).
Yeah, posting to n.p.m.? would probably be a good idea but I dunno which group
would be the best.
Thanks for the feedback.
I sent the following to the reporter a whlie ago, i'm reproducing it here
because someone asked me to address this bug. unfortunately, i'm typing
blindly, so i'm not going to make any edits, just paste:
neilconway@home.com wrote:
> WRT: additional files: Woops, I must have missed some
you might have, or they might not have been there...
> does 'make -f client checkout' not checkout the entire tree?
it does not. some parts of the tree (eg webtools) aren't necessary to mozilla
browser development.
> I'll check that and upload a new patch when I get a chance
> (or else someone else can, it's not exactly rocket science ;-) ).
but it's so much fun
> Yeah, posting to n.p.m.? would probably be a good idea
> but I dunno which group would be the best.
hopefully someone will have ideas.
> Thanks for the feedback.
:-)
Comment 9•23 years ago
|
||
I just tried searching for depricated using LXR. There are a zillion occurences
of MWJavaDoc_Proj_Depricated in macbuild xml files. Is it possible to do a
global replace in Mozilla source replacing depricated with deprecated (since
there are _so_ many occurences?
Comment 10•18 years ago
|
||
Merged with bug #106386
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•