Closed Bug 938346 Opened 11 years ago Closed 11 years ago

attachment flag labeling doesn't ignore obsolete attachments

Categories

(Websites :: Scrumbugs, defect, P2)

x86_64
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: huseby, Assigned: huseby)

Details

(Whiteboard: [c= p= s= u=])

Attachments

(2 files)

When the attachment flags are processed to build the set of flags, obsolete attachments aren't being ignored. The end result is that we get inaccurate lists of outstanding flags. We just need to add the "is_obsolete" flag to the BZ_ATTACHMENT_FIELDS in bugzilla/api.py and then when we are processing attachment flags in Bug.bucketed_flags and Bug.flags_status, we just need to skip any attachments where "is_obsolete" is true.
Whiteboard: [c= p= s= u=]
Status: NEW → ASSIGNED
Attached file github pull request
this bug was annoying me this morning and I knew it would take me 5 minutes to fix it...so I did.
Attachment #832285 - Flags: review?(pmac)
Comment on attachment 832285 [details] [review] github pull request clearing review? flag since it was just merged.
Attachment #832285 - Flags: review?(pmac)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: