938383 - Improve charCode handling in Gonk key events

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[Michael Wu [:mwu]]

Attachment: Improve charCode handling in gonk widget backend

This fixes gonk keyevent handling so only one of keycode/charcode is set at a time.

The docs seem to suggest that keyCode should not be set on key press if we could not determine the charcode, but that appears to break backspace on my dev board.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Comment on attachment 831857 [details] [diff] [review]
Improve charCode handling in gonk widget backend

If you don't mind, please add {} for each if/else block, which is our generic coding rule. However, I'm not sure the local rule of Gonk widget.

Comment 2

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/b2g-inbound/rev/a32feef503fc

Checked in with curly braces.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a32feef503fc