938388 - Convert all remaining code for calculating path lengths and position at an offset along a path in content/svg to Moz2D (kill off all uses of gfxPath)

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

Following on from bug 934305, this patch converts all remaining path handling in content/svg to Moz2D.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 831863 [details] [diff] [review]
patch

>+++ b/content/svg/content/src/SVGMotionSMILAnimationFunction.h
>+  PathSourceType             mPathSourceType; // source of our Path.
>+  mozilla::RefPtr<Path>      mPath;           // representation of motion path.
>   nsTArray<double>           mPathVertices; // distances of vertices along path.
> 
>   bool                       mIsPathStale;
> };
> 
> } // namespace mozilla

I don't think we need the "mozilla::" prefix there, since this code is inside of namespace mozilla {}, right?

>+++ b/content/svg/content/src/SVGMotionSMILPathUtils.cpp
>-already_AddRefed<gfxPath>
>+TemporaryRef<Path>
> SVGMotionSMILPathUtils::PathGenerator::GetResultingPath()
> {
>   RefPtr<Path> path = mPathBuilder->Finish();
>-  nsRefPtr<gfxPath> thebesPath = new gfxPath(path);
>-  return thebesPath.forget();
>+  return path.forget();
> }

No need for the |path| local-var here anymore. We can just directly return mPathBuilder->Finish() (making this a one-liner).

r=me

Comment 3

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af0931327e49

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/af0931327e49