938393 - Let nsIWindowWatcher expose a HasWindowCreator method

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GRE Core, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: add HasWindowCreator

In Bug 937204, I have widget/android/ code that waits for a monitor to get notified by the compositor; and that causes a xpcshell test to stall as in xpcshell we don't have a compositor, because we don't have a window.

Of course, that means that xpcshell is an imperfect choice for what this test is doing (xpcshell is not the best for even loosely gfx-related things), but since the code I'm touching here is 'legacy', I am hoping that I won't have to port these tests away from xpcshell.

So with help from Ehsan I looked into what determines that xpcshell doesn't create a window, and the answer is that it doesn't SetWindowCreator on the nsIWindowWatcher.

So the present patch adds a HasWindowCreator getter to nsIWindowWatcher, which tells me exactly what I need to know (for practical purposes, it tells me whether I'm running in xpcshell, but it's much more to the point of what I actually need to know than literally checking if I'm xpcshell).

I hope that that's reasonable.

Comment 1

[Benjamin Smedberg]

Comment on attachment 831865 [details] [diff] [review]
add HasWindowCreator

rev the nsIWindowWatcher IID

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

https://hg.mozilla.org/integration/b2g-inbound/rev/c50ed59b010f

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

bustage fix, https://hg.mozilla.org/integration/b2g-inbound/rev/5f85b786d85e

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

https://hg.mozilla.org/integration/b2g-inbound/rev/c275cfda1639

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c50ed59b010f
https://hg.mozilla.org/mozilla-central/rev/5f85b786d85e
https://hg.mozilla.org/mozilla-central/rev/c275cfda1639