938442 - require("sdk/window/utils").open() must open window with default features

Status: RESOLVED INCOMPLETE

(Add-on SDK Graveyard :: General, defect, P3)

Description

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Currently require("sdk/window/utils").open() opens window with no chrome, that's because features ares serialized to `""`. Instead if features are not passed we
should pass `null` into `windowWatcher.openWindow` so that it will use default set
of features.

Comment 1

[Tomislav Jovanovic :zombie]

this seems simple enough, so i'm gonna label it [good first bug], as we are running low on those.

if anyone wants to take this, just post a comment here, i'm sure Irakli won't mind.

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Irakli are you working on this?

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

zombie: Good first bug sound fine by me.
Erik: I had a patch in one of my branches, basically features shouldn't be an empty string, it should be `null`.

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Irakli Gozalishvili [:irakli] [:gozala] [@gozala] from comment #3)
> zombie: Good first bug sound fine by me.
> Erik: I had a patch in one of my branches, basically features shouldn't be
> an empty string, it should be `null`.

So should this bug be assigned to you still?

Comment 5

[Andy McKay]

Because of the difficulty finding mentors and the expected life span of the SDK, we are removing [good first bug] from remaining SDK bugs.

Comment 6

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1399562