938469 - QFB buttons :active logic is incorrect

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Josiah Bruner [:jsbruner]]

Currently on OS X one can press and hold down on a QFB button and examine its image change color from gray to white. However, if while you are holding down you move the mouse out of the button, the image becomes gray again, which does not contrast well with the rest of the button. We should simply move the :active calls to point at the white image instead.

Patch coming up.

Comment 1

[Josiah Bruner [:jsbruner]]

Attachment: Patch.

This fixes the problem. (Sorry for all the reviews Richard :))

Comment 2

[:aceman]

Are other platforms unaffected?

Comment 3

[Josiah Bruner [:jsbruner]]

(In reply to :aceman from comment #2)
> Are other platforms unaffected?

Nope. Only OS X.

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 832007 [details] [diff] [review]
Patch.

Review of attachment 832007 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Thank you, Josiah.

Comment 5

[Josiah Bruner [:jsbruner]]

https://hg.mozilla.org/comm-central/rev/c7205791228e

(Sorry for leaving off the r=Paenglab in the commit message, forgot a qrefresh before pushing apparently)