938529 - [bluedroid] Set BT_SCAN_MODE to Connectable after Bluetooth turned on

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

[bluedroid] Set BT_SCAN_MODE to Connectable after Bluetooth turned on.
Otherwise, Page is disabled. All connection will be blocked.

Comment 1

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 938529 - [bluedroid] Set BT_SCAN_MODE to Connectable after Bluetooth turned on

Comment 2

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

This patch is based on new architecture after patch sets in Bug 936732 commit.

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

This can resolve incoming connection request ended up with Page Timeout.

Comment 4

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 832168 [details] [diff] [review]
Bug 938529 - [bluedroid] Set BT_SCAN_MODE to Connectable after Bluetooth turned on

Review of attachment 832168 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit addressed.

::: dom/bluetooth/bluedroid/gonk/BluetoothServiceBluedroid.cpp
@@ +167,5 @@
>    BT_LOGD("%s, BT_STATE:%d", __FUNCTION__, aStatus);
>    nsAutoString signalName;
> +  bt_property_t prop;
> +  bt_scan_mode_t mode;
> +  prop.type = BT_PROPERTY_ADAPTER_SCAN_MODE;

nit: please move these variables into the if-block since they are only used inside.

Comment 5

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

The same concern that I have, these variables scope only in if-block, we could hit problem that we resolved previously regarding set_property. So do we really need to change it?

Comment 6

[Eric Chou [:ericchou] [:echou]]

(In reply to Shawn Huang [:shuang] [:shawnjohnjr] from comment #5)
> The same concern that I have, these variables scope only in if-block, we
> could hit problem that we resolved previously regarding set_property. So do
> we really need to change it?

All we have to do is make sure arguments passed into set_adapter_property() would be still alive when set_adapter_property() is called.

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 938529 - [bluedroid] Set BT_SCAN_MODE to Connectable after Bluetooth turned on, r=echou

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/75516a2a7c3e

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/75516a2a7c3e