boxes with overheadIndicator have too much space at the bottom

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: teoli, Unassigned)

Tracking

Details

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 832157 [details]
Screen Shot 2013-11-14 at 11.06.50.png

We are really in small nit's right now :-)

Most of our boxes use this HTML:
<div class="overheadIndicator draft">
    <p><strong><%=s_draft%></strong><br/>
    <%=s_not_complete%></p>
</div>

(Draft being changed to other things, I believe it is overheadIndicator).

The space after the <p> is too long, it should be symmetrical (more or less) with what is before. I'm adding three screenshots to show the current results.
(Reporter)

Comment 1

5 years ago
Created attachment 832158 [details]
Non-standard
(Reporter)

Comment 2

5 years ago
Created attachment 832159 [details]
Obsolete box
JYP: What CSS classes should we remove the bottom spacing from?  I'm already doing so from ".warning" and ".bug".  Is ".overheadIndicator" the only other one?
(Reporter)

Comment 4

5 years ago
I would say yes, because it is used by all our standard banners. They may be unusual banner having a different class but we should convert them to overheadIndicator I guess.
(Reporter)

Updated

5 years ago
Summary: boxes with overheadIndicator have to much spaces at the bottom → boxes with overheadIndicator have too much space at the bottom

Updated

5 years ago
Blocks: 925145
No longer blocks: 910513
Priority: -- → P1

Comment 5

5 years ago
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/67768495092a04e6ced5b80a5eb411b303acb0ef
fix bug 938552 - Prevent too much spacing at the bottom of overheadIndicator boxes

https://github.com/mozilla/kuma/commit/9d763c638621d6040a278592348d0ad611becc83
Merge pull request #1673 from darkwing/box-space-938552-again

fix bug 938552 - Prevent too much spacing at the bottom of overheadIndicator boxes

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.