938568 - unprivileged users getting "You tried to change the blocking-b2g field from --- to --- , but only the assignee or reporter of the bug, or a user with the required permissions may change that field." error

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[:glob ✱]

steps:

1. load a bug with the blocking_b2g tracking flag visible as an user without editbugs
2. do not make any changes, hit submit

Comment 2

[:glob ✱]

Attachment: 938568_1.patch

this addresses two issues:

the critical issue that was introduced today which was incorrectly detecting and blocking no-ops as changes (bug in the setter -- it sometimes gets passed an array ref in $new_value).

the second issue is unprivileged users were not able to set tracking flags to values like "leo?", even if that value is configured to allow everyone.  this was due to a missing bug_check_can_change_field sub.

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 832211 [details] [diff] [review]
938568_1.patch

Review of attachment 832211 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

::: extensions/TrackingFlags/Extension.pm
@@ +511,5 @@
> +    my ($self, $args) = @_;
> +    my ($bug, $field, $old_value, $new_value, $priv_results)
> +        = @$args{qw(bug field old_value new_value priv_results)};
> +
> +    return if $field !~ /^cf_/ or $old_value ne $new_value;

Needs to be $old_value eq $new_value. Fix on commit.

Comment 5

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/TrackingFlags/Extension.pm
modified extensions/TrackingFlags/template/en/default/hook/global/user-error-errors.html.tmpl
Committed revision 9144.

will get this pushed to production asap.