Closed Bug 938577 Opened 12 years ago Closed 12 years ago

Write a test for using the email keyboard

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
Other
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v1.2 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: zcampbell, Assigned: jakub.s.jarosz)

References

Details

Attachments

(2 files)

github pr
46 bytes, text/x-github-pull-request
zcampbell
: review+
AndreiH
: review+
Details | Review
PR https://github.com/mozilla-b2g/gaia/pull/13707
46 bytes, text/x-github-pull-request
AlinT
: review-
bsilverberg
: review+
Details | Review
Write a test for the email keyboard, make sure the `@` key is present/usable.
Attached file github pr —
Attachment #832202 - Flags: review?(zcampbell)
Attachment #832202 - Flags: review?(andrei.hutusoru)
Attachment #832202 - Flags: review?(andrei.hutusoru) → review+
Comment on attachment 832202 [details] [review] github pr r+!!
Attachment #832202 - Flags: review?(zcampbell) → review+
Merged to master: https://github.com/mozilla-b2g/gaia/commit/603f7e0d23f2b693f17fce61ffcdc641a3a6aba6 We can merge this to v1.2 setting -> affected
status-b2g18: --- → affected
Attachment #832277 - Flags: review?(trifandreialin)
Attachment #832277 - Flags: review?(moz.teodosia)
Attachment #832277 - Flags: review?(bob.silverberg)
(In reply to Zac C (:zac) from comment #3) > Merged to master: > https://github.com/mozilla-b2g/gaia/commit/ > 603f7e0d23f2b693f17fce61ffcdc641a3a6aba6 > > We can merge this to v1.2 setting -> affected Should be b2g-v1.2, not b2g18. :)
status-b2g18: affected → ---
status-b2g-v1.2: --- → affected
Comment on attachment 832277 [details] [review] PR https://github.com/mozilla-b2g/gaia/pull/13707 The test is failing on v1.2.
Attachment #832277 - Flags: review?(bob.silverberg) → review-
Attachment #832277 - Flags: review?(trifandreialin) → review-
Comment on attachment 832277 [details] [review] PR https://github.com/mozilla-b2g/gaia/pull/13707 Updated the pull
Attachment #832277 - Flags: review?(trifandreialin)
Attachment #832277 - Flags: review?(bob.silverberg)
Attachment #832277 - Flags: review-
Comment on attachment 832277 [details] [review] PR https://github.com/mozilla-b2g/gaia/pull/13707 Comments in the PR.
Attachment #832277 - Flags: review?(bob.silverberg) → review-
Comment on attachment 832277 [details] [review] PR https://github.com/mozilla-b2g/gaia/pull/13707 there is one still issue here that needs to be addressed.
Attachment #832277 - Flags: review?(trifandreialin) → review-
Depends on: 927870
Comment on attachment 832277 [details] [review] PR https://github.com/mozilla-b2g/gaia/pull/13707 Fixed merge conflicts!
Attachment #832277 - Flags: review- → review?(bob.silverberg)
Comment on attachment 832277 [details] [review] PR https://github.com/mozilla-b2g/gaia/pull/13707 The test is passing, but the PR needs to address one comment.
Attachment #832277 - Flags: review?(bob.silverberg) → review-
Attachment #832277 - Flags: review- → review?(bob.silverberg)
Status: NEW → RESOLVED
Closed: 12 years ago
status-b2g-v1.2: affected → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: