Closed
Bug 938577
Opened 11 years ago
Closed 11 years ago
Write a test for using the email keyboard
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(b2g-v1.2 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| b2g-v1.2 | --- | fixed |
People
(Reporter: zcampbell, Assigned: jakub.s.jarosz)
References
Details
Attachments
(2 files)
Write a test for the email keyboard, make sure the `@` key is present/usable.
|
Reporter | |
Comment 1•11 years ago
|
||
Attachment #832202 -
Flags: review?(zcampbell)
Attachment #832202 -
Flags: review?(andrei.hutusoru)
|
||
Updated•11 years ago
|
Attachment #832202 -
Flags: review?(andrei.hutusoru) → review+
|
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 832202 [details] [review] github pr r+!!
Attachment #832202 -
Flags: review?(zcampbell) → review+
|
|
Reporter | |
Comment 3•11 years ago
|
||
Merged to master: https://github.com/mozilla-b2g/gaia/commit/603f7e0d23f2b693f17fce61ffcdc641a3a6aba6 We can merge this to v1.2 setting -> affected
status-b2g18:
--- → affected
|
|
||
Comment 4•11 years ago
|
||
Attachment #832277 -
Flags: review?(trifandreialin)
Attachment #832277 -
Flags: review?(moz.teodosia)
Attachment #832277 -
Flags: review?(bob.silverberg)
|
||
Comment 5•11 years ago
|
||
(In reply to Zac C (:zac) from comment #3) > Merged to master: > https://github.com/mozilla-b2g/gaia/commit/ > 603f7e0d23f2b693f17fce61ffcdc641a3a6aba6 > > We can merge this to v1.2 setting -> affected Should be b2g-v1.2, not b2g18. :)
status-b2g18:
affected → ---
status-b2g-v1.2:
--- → affected
|
|
||
Comment 6•11 years ago
|
||
Comment on attachment 832277 [details] [review] PR https://github.com/mozilla-b2g/gaia/pull/13707 The test is failing on v1.2.
Attachment #832277 -
Flags: review?(bob.silverberg) → review-
|
||
Updated•11 years ago
|
Attachment #832277 -
Flags: review?(trifandreialin) → review-
|
|
||
Comment 7•11 years ago
|
||
Comment on attachment 832277 [details] [review] PR https://github.com/mozilla-b2g/gaia/pull/13707 Updated the pull
Attachment #832277 -
Flags: review?(trifandreialin)
Attachment #832277 -
Flags: review?(bob.silverberg)
Attachment #832277 -
Flags: review-
|
|
||
Comment 8•11 years ago
|
||
Comment on attachment 832277 [details] [review] PR https://github.com/mozilla-b2g/gaia/pull/13707 Comments in the PR.
Attachment #832277 -
Flags: review?(bob.silverberg) → review-
|
|
||
Comment 9•11 years ago
|
||
Comment on attachment 832277 [details] [review] PR https://github.com/mozilla-b2g/gaia/pull/13707 there is one still issue here that needs to be addressed.
Attachment #832277 -
Flags: review?(trifandreialin) → review-
|
|
||
Comment 10•11 years ago
|
||
Comment on attachment 832277 [details] [review] PR https://github.com/mozilla-b2g/gaia/pull/13707 Fixed merge conflicts!
Attachment #832277 -
Flags: review- → review?(bob.silverberg)
|
|
||
Comment 11•11 years ago
|
||
Comment on attachment 832277 [details] [review] PR https://github.com/mozilla-b2g/gaia/pull/13707 The test is passing, but the PR needs to address one comment.
Attachment #832277 -
Flags: review?(bob.silverberg) → review-
|
|
||
Updated•11 years ago
|
Attachment #832277 -
Flags: review- → review?(bob.silverberg)
|
|
||
Comment 12•11 years ago
|
||
Comment on attachment 832277 [details] [review] PR https://github.com/mozilla-b2g/gaia/pull/13707 Landed on v1.2 in https://github.com/mozilla-b2g/gaia/commit/db2b35235fb11d29bb050290d6f1ef4bb5e0acbf
Attachment #832277 -
Flags: review?(moz.teodosia)
Attachment #832277 -
Flags: review?(bob.silverberg)
Attachment #832277 -
Flags: review+
|
|
||
Updated•11 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•