938646 - [B2G][Dialer] Contact picture on call waiting persists on the ongoing call screen of another contact after ignoring call

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[abhinav.srivstva]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/29.0.1547.65 Safari/537.36

Steps to reproduce:

Was on a call with gf, A (with no picture)


Actual results:

Got a call waiting from another girl, B (with picture)

I obviously ignored the call waiting but i found that the picture of girl B has taken over the screen of my ongoing call with A



Expected results:

The picture of A should have been there on the ongoing call screen instead of B's


Bit scary :)

Comment 1

[abhinav.srivstva]

build prerelease 1.2.0.0

Comment 2

[Matthew Vaughan]

Confirmed... this bug does reproduce on the 11/18/13 1.2 build with COM RIL.

Description:
The contact image of a caller on call waiting will persist on the screen even after ignoring their call. This will occur if the user pressing the "Ignore Call" button or lets the call go to voice mail. Additionally, this will occur if one contact has an image or if both contacts have an image. 

Prerequisites:
1) Have call waiting enabled on test phone (A)
2) Have to other phones (B & C) available

Repro Steps:
1) Update Buri to v1.2 COM RIL BuildID: 20131118004001
2) Create two contacts in A for B & C; give each B and C a contact image
3) Call A using C and answer the call
4) While on the line with C, call A using B
5) When call waiting is triggered, select "Ignore Call"

Actual:
The contact image for B remains on the screen while C is on the line.

Expected:
The contact image for B is not displayed after ignoring the call and the image for C is displayed.

Environmental Variables:
Device: Buri v1.2 COM RIL
BuildID: 20131118004001
Gaia: 7a23f8c53ba97da9c63a7275b36d155b4526a639
Gecko: 3e8b854a992e
Version: 26.0
Firmware Version: 20131115
RIL Version: 01.02.00.019.102

Notes:
Repro frequency: 3/3
See attached: ContactImagePersist.3gp

Comment 3

[Matthew Vaughan]

Attachment: Video of issue occurring.

Comment 4

[Matthew Vaughan]

This issue does reproduce on the 11/19/13 1.1 build with COM RIL.

Environmental Variables:
Device: Leo v1.1 COM RIL
BuildID: 20131119041201
Gaia: b585b32441fafa67f2b4582db23be5f3a2afab21
Gecko: 7c3cfc0936ca
Version: 18.0
RIL Version: 01.01.00.019.281

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

as mentioned in bug 946072.. there's no event coming to active call when ignoring. I wonder if we
have to do the switch back in CallHandler.ignore().

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

sorry, it's bug 940672

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

nominating 1.3? for wrong behavior.

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

WIP:
https://github.com/rexboy7/gaia/commit/c408e33c3bf01e54cd07bf455d97a66db2c1fbd1

This works but I would like to try whether I can dispatch events on call to update images..

Comment 9

[KM Lee [:rexboy] (inactivate after Sep. 22)]

WIP 2:
https://github.com/rexboy7/gaia/commit/3358d41c3b4be371aebe945c6725712e46a9b931

Also works and more clear. I'm preferring this one...but not sure if using
CustomEvent on call/ConferenceCall object is appropriate. Will ask owner of telephony later.
(Unit test not completed yet)

Comment 10

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

I tried to uses CustomEvent to solve the problem (so that changing image can be kept inside wrapper classes). Confirmed with Hsinyi that this is allowed, but not sure if it's a good idea.
Etienne may you give some comments on this propose?

I'll finish unit tests once confirming solution.
(for reference, The WIP 1 above is the solution without using customEvent)

Comment 11

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8342898 [details]
patch

Since this is not a completed patch yet I think using feedback may be more appropriate.

Comment 12

[Etienne Segonzac (:etienne)]

Comment on attachment 8342898 [details]
patch

I think we could do something simpler:

* In CallScreen.hideIncoming
  - we check CallsHandler.activeCall
    + if we have one, we call this.setCallerContactImage(handledCall.photo)
    + if not (in the conference call case for example), we setCallerContactImage(null)

It should do the trick.
Also, nice catch in conference_group_handler.js, let's keep this change in the patch :)

Comment 13

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8342898 [details]
patch

Oh, much simpler! Thanks for the suggestion.

Just completed the unit tests with suggestions in comment 12.
Ended up with much more test codes than main app codes :-O
And if this patch landed, we can close bug 946072 also.

Comment 14

[KM Lee [:rexboy] (inactivate after Sep. 22)]

sorry again, it's bug 940672.

Comment 15

[Etienne Segonzac (:etienne)]

(In reply to KM Lee [:rexboy] from comment #13)
> Ended up with much more test codes than main app codes :-O

Just like I like it :)
Seriously, I'm grateful for the added coverage in call_screen_test.js

Comment 16

[Etienne Segonzac (:etienne)]

Comment on attachment 8342898 [details]
patch

Good to go, awesome work!

Comment 17

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Thanks for the reviewing!! :)

Just rebased and squashed withe a green travis. Closing this bug.
master:
https://github.com/mozilla-b2g/gaia/commit/a3e8ed494afd7ec3ba8181c3549e4a7d780d13d8

Comment 18

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted a3e8ed494afd7ec3ba8181c3549e4a7d780d13d8 to:
v1.3 already had this commit