Closed
Bug 938707
Opened 11 years ago
Closed 11 years ago
Improve waits in test_settings_do_not_track
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(b2g-v1.2 affected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| b2g-v1.2 | --- | affected |
People
(Reporter: bsilverberg, Assigned: bsilverberg)
References
Details
Attachments
(2 files)
This test is failing. See: http://qa-selenium.mv.mozilla.com:8080/job/b2g.hamachi.mozilla-central.ui/279/HTML_Report/?
|
Assignee | |
Comment 1•11 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Updated•11 years ago
|
Attachment #832395 -
Flags: review?(zcampbell)
Attachment #832395 -
Flags: review?(trifandreialin)
Attachment #832395 -
Flags: review?(moz.teodosia)
Attachment #832395 -
Flags: review?(florin.strugariu)
Attachment #832395 -
Flags: review?(andrei.hutusoru)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 832395 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13718 r+
Attachment #832395 -
Flags: review?(trifandreialin) → review+
|
||
Updated•11 years ago
|
Attachment #832395 -
Flags: review?(moz.teodosia) → review+
|
||
Updated•11 years ago
|
Attachment #832395 -
Flags: review?(andrei.hutusoru) → review-
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 832395 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13718 I updated the PR.
Attachment #832395 -
Flags: review?(trifandreialin)
Attachment #832395 -
Flags: review?(moz.teodosia)
Attachment #832395 -
Flags: review?(andrei.hutusoru)
Attachment #832395 -
Flags: review-
Attachment #832395 -
Flags: review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
As this has become a "test improvement" PR as opposed to a test fix, this now also applies to v1.2.
|
|
Assignee | |
Updated•11 years ago
|
Summary: Fix failure of test_settings_do_not_track → Improve waits in test_settings_do_not_track
|
||
Updated•11 years ago
|
Attachment #832395 -
Flags: review?(florin.strugariu) → review+
|
||
Comment 7•11 years ago
|
||
Comment on attachment 832395 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13718 r+ but won't merge until I see the green Travis.
Attachment #832395 -
Flags: review?(zcampbell) → review+
|
|
||
Comment 8•11 years ago
|
||
Good travis! Merged to master: https://github.com/mozilla-b2g/gaia/commit/fe38a914ba9ceedccad10eb69eac0f38a102e67b
|
|
||
Comment 9•11 years ago
|
||
Comment on attachment 832395 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13718 As this does not affect v1.2 I am changing this as resolved. Thanks!
Attachment #832395 -
Flags: review?(trifandreialin)
Attachment #832395 -
Flags: review?(moz.teodosia)
Attachment #832395 -
Flags: review?(andrei.hutusoru)
Attachment #832395 -
Flags: review+
|
|
||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Comment 10•11 years ago
|
||
This is the kind of test enhancement that is good for v1.2 even if it's not suffering from the intermittent error just now.
Status: RESOLVED → UNCONFIRMED
Ever confirmed: false
Resolution: FIXED → ---
|
|
Assignee | |
Comment 11•11 years ago
|
||
Agreed, Zac. Also note that status-b2g-v1.2 was already listed as affected, so the decision that this _should_ apply to v1.2 was already made. Please check that before closing any bugs.
|
|
||
Comment 12•11 years ago
|
||
you're right guys, sorry for closing this. I will make a pull for v1.2
|
|
||
Comment 13•11 years ago
|
||
Pointer to Github pull-request
|
|
||
Comment 14•11 years ago
|
||
Comment on attachment 8334478 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13831 Uplifting to v1.2
Attachment #8334478 -
Flags: review?(trifandreialin)
Attachment #8334478 -
Flags: review?(moz.teodosia)
Attachment #8334478 -
Flags: review?(bob.silverberg)
|
|
||
Updated•11 years ago
|
Attachment #8334478 -
Flags: review?(moz.teodosia) → review+
|
|
||
Updated•11 years ago
|
Attachment #8334478 -
Flags: review+
|
|
||
Comment 15•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/8ff13cf43d185104a000bab68f5eef589b5d8684
|
|
||
Updated•11 years ago
|
Attachment #8334478 -
Flags: review?(trifandreialin)
Attachment #8334478 -
Flags: review?(bob.silverberg)
|
|
||
Comment 16•11 years ago
|
||
Merged: master: https://github.com/mozilla-b2g/gaia/commit/fe38a914ba9ceedccad10eb69eac0f38a102e67b 1.2: https://github.com/mozilla-b2g/gaia/commit/8ff13cf43d185104a000bab68f5eef589b5d8684
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•