938716 - Unable to select/deselect devices for Paid apps

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P1)

Description

[krupa raj[:krupa]]

Attachment: select devices.png

NOTE: Payments is enabled for Android in stage

steps to reproduce:
1. Load https://marketplace.allizom.org/developers/submit/
2. Select Paid app tab
3. Upload an app after selection FirefoxOS, Firefox Mobile and Firefox Tablet
4. After submission, click on 'Set Up Payments'
5. https://marketplace.allizom.org/developers/app/test-app-c0k7/payments/ loads
6. Try to change the supported devices

expected behavior:
User can select deselect device options from the Compatibility & Payments page

observed behavior:
User can select deselect device options from the Compatibility & Payments page since there are no checkboxes. See screenshot.

Comment 1

[Andy McKay]

Could you take a look at this Stuart please?

Comment 2

[Stuart Colville [:muffinresearch]]

https://github.com/mozilla/zamboni/commit/45cb6e6b731b1bc4928cd1f549d5a1c946e0f86c

Comment 3

[Victor Carciu]

The checkboxes are now available but two new issues were encountered:

1.There is a "Change to paid" button available even if the app is already paid
1."Save" button is missing for this section

Comment 4

[Stuart Colville [:muffinresearch]]

(In reply to Victor Carciu from comment #3)
> The checkboxes are now available but two new issues were encountered:
> 
> 1.There is a "Change to paid" button available even if the app is already
> paid
> 1."Save" button is missing for this section

Good catch.

This commit should rectify the issues. Note the save button appears when changes as this is how it works for Free too.

https://github.com/mozilla/zamboni/commit/31861a803b973ebf30fd47394adc6f09f4cd54a8

Comment 5

[Victor Carciu]

The issue is still reproducible on Stage exactly as described in comment #4. Save button not present when devices are changed.

Comment 6

[Stuart Colville [:muffinresearch]]

(In reply to Victor Carciu from comment #5)
> The issue is still reproducible on Stage exactly as described in comment #4.
> Save button not present when devices are changed.

That'll be because stage isn't up to date with this change.

Comment 7

[Victor Carciu]

(In reply to Stuart Colville [:scolville] from comment #6)
> (In reply to Victor Carciu from comment #5)
> > The issue is still reproducible on Stage exactly as described in comment #4.
> > Save button not present when devices are changed.
> 
> That'll be because stage isn't up to date with this change.

I understand, but I can't test on -dev because only one device is available for paid apps(FF OS).

Comment 8

[Stuart Colville [:muffinresearch]]

Additional fix to logic for cannot_be_paid - https://github.com/mozilla/zamboni/commit/0cb5017de832fb197ae318c0292ce6aa65558c5a

Will look to get staging updated as soon as possible.

Comment 9

[Stuart Colville [:muffinresearch]]

Marking as fixed - noting testing will only be possible once 0cb5017 is on staging.

Comment 10

[Stuart Colville [:muffinresearch]]

(In reply to Victor Carciu from comment #7)
> (In reply to Stuart Colville [:scolville] from comment #6)
> > (In reply to Victor Carciu from comment #5)
> > > The issue is still reproducible on Stage exactly as described in comment #4.
> > > Save button not present when devices are changed.
> > 
> > That'll be because stage isn't up to date with this change.
> 
> I understand, but I can't test on -dev because only one device is available
> for paid apps(FF OS).

Yep - you could always flip the waffle flag android-payments on -dev to test there.

Comment 11

[Stuart Colville [:muffinresearch]]

@Victor 0cb5017 is on stage now.

Comment 12

[Victor Carciu]

(In reply to Stuart Colville [:scolville] from comment #11)
> @Victor 0cb5017 is on stage now.

Thank you Stuart!
Verified as fixed : http://screencast.com/t/r1AP9lZ0vB