Closed
Bug 938740
Opened 11 years ago
Closed 11 years ago
Update libpng to version 1.6.7
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: glennrp+bmo, Assigned: glennrp+bmo)
References
()
Details
(Whiteboard: [qa-])
Attachments
(1 file, 3 obsolete files)
66.39 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
libpng-1.6.7 was released today. It adds ARMv8 support and improved unknown-chunk handling.
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Comment 1•11 years ago
|
||
The v00 patch doesn't enable ARM; that will be taken care of in another bug.
Flags: needinfo?(ryanvm)
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 832684 [details] [diff] [review] v00 Update libpng to version 1.6.7 The v00 patch is incomplete; several source files weren't updated to version 1.6.7.
Attachment #832684 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Flags: needinfo?(ryanvm)
Assignee | ||
Comment 3•11 years ago
|
||
Flags: needinfo?(ryanvm)
Assignee | ||
Comment 4•11 years ago
|
||
Add #ifdef PNG_HANDLE_AS_UNKNOWN_SUPPORTED/#endif to pngpread.c to work around a libpng-1.6.7 bug. Add #define MOZ_PNG_* to mozpngconf.h for new libpng-1.6.7 symbols Omit unused pngwtran.c from UNIFIED_SOURCES in moz.build
Attachment #833366 -
Attachment is obsolete: true
Assignee | ||
Comment 5•11 years ago
|
||
Some of the pngsuite images at schaik.com are failing. Don't need a try run until I get this fixed on my local platform.
Flags: needinfo?(ryanvm)
Assignee | ||
Comment 6•11 years ago
|
||
The v03 patch fixes a bug in libpng-1.6.7, in which the prototype for png_handle_unknown() is wrongly #ifdef'ed out of pngpriv.h
Attachment #8333559 -
Attachment is obsolete: true
Flags: needinfo?(ryanvm)
Comment 7•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=88789689df41
Flags: needinfo?(ryanvm)
Assignee | ||
Comment 8•11 years ago
|
||
The try was mostly green. The three reds seem to have nothing to do with libpng.
Comment 9•11 years ago
|
||
Yep, known infrastructure issues. Retriggers are green.
Assignee | ||
Updated•11 years ago
|
Attachment #8334067 -
Flags: review?(jmuizelaar)
Updated•11 years ago
|
Attachment #8334067 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 10•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c590c170652b
Keywords: checkin-needed
Comment 11•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c590c170652b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•