938806 - Handle errors better in GonkFMRadio

Status: RESOLVED FIXED

(Core :: Hardware Abstraction Layer (HAL), defect)

Description

[Michael Wu [:mwu]]

Right now, we don't necessarily report failures while setting up the FM radio. This needs to be fixed.

Comment 1

[Michael Wu [:mwu]]

Attachment: Improve error handling in FM radio init path

Comment 2

[Dave Hylands [:dhylands]]

Comment on attachment 8439431 [details] [diff] [review]
Improve error handling in FM radio init path

Review of attachment 8439431 [details] [diff] [review]:
-----------------------------------------------------------------

I like it.

::: hal/gonk/GonkFMRadio.cpp
@@ +300,5 @@
>  
>    if (sMsmFMMode) {
>      sRadioFD = fd.forget();
>      sMsmFMVersion = cap.version;
>      pthread_create(&sRadioThread, nullptr, runMsmFMRadio, nullptr);

Should this code path also generate some type of notification? Right now it looks like all of the other ways of exiting this function will create a notification, except for this one.

Comment 3

[Michael Wu [:mwu]]

runMsmFMRadio is suppose to generate its own notification. I suppose if pthread_create fails, that won't happen. I'll add a check for that too.

Comment 4

[Michael Wu [:mwu]]

Attachment: improve-fm-init-error-handling-v2

This also ensures pthread_create succeeds.

Comment 5

[Dave Hylands [:dhylands]]

Comment on attachment 8439549 [details] [diff] [review]
improve-fm-init-error-handling-v2

Review of attachment 8439549 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 6

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/b2g-inbound/rev/5bb301cd0e7c

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5bb301cd0e7c