Closed
Bug 938823
Opened 11 years ago
Closed 11 years ago
[mozlog] Add parameter for printing timestamps
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mcote, Unassigned)
References
Details
Attachments
(1 file)
|
3.01 KB,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
MozFormatter() doesn't include timestamps by default, since they are produced by mozharness. However, for standalone tools, this would be very useful. I suppose maybe I should be using structured logging, but my intended use is specifically for humans, while debugging, so I think plain logging makes more sense here.
|
Assignee | |
Comment 1•11 years ago
|
||
Feel like taking a look? Includes test!
Attachment #832657 -
Flags: review?(wlachance)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 832657 [details] [diff] [review] 0001-Bug-938927-Option-to-include-timestamp-in-MozFormatt.patch Looks good!
Attachment #832657 -
Flags: review?(wlachance) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://github.com/mozilla/mozbase/commit/1e6a6facb38b5af85c576d151714fcf9a027ce7e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•