938941 - [UI][OS X] Make all sidebar entries in the library behave the same way on hover

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: Library sidebar item behavior on hover

Currently there are two ways a sidebar item in the library can behave on hover:
Behavior 1: add an underline and show a hand cursor (like hyperlinks)
Behavior 2: don't change

All items should behave should use behavior 2 of not having a distinct hover state.

Behavior 1 triggers the wrong associations (hyperlink) and both types of items actually do the same thing on click, namely showing content in the right panel.

Comment 1

[Darrin Henein [:darrin]]

Attachment: patch 0.1

This patch removes some CSS to unify the hover states in the Places sidebar.

Comment 2

[Darrin Henein [:darrin]]

Attachment: places-css-changes.patch

Removed Windows CSS as well.

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8361051 [details] [diff] [review]
places-css-changes.patch

Review of attachment 8361051 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay, I knew something wasn't right but needed to fire up Windows and Linux machines to verify.

As far as I can tell and after talking with shorlander, this is only a problem on OS X in the organizer. We still want the hover styling on Windows and Linux for the bookmark and history sidebars (outside the places organizer) to match platform conventions.

I pushed the patch for you as I don't think you have commit access. Thanks for the patch!

https://hg.mozilla.org/integration/fx-team/rev/93c4d9d7ad46

::: browser/themes/linux/places/places.css
@@ -13,5 @@
> -}
> -
> -.sidebar-placesTreechildren::-moz-tree-cell-text(leaf, hover) {
> -  cursor: pointer;
> -  text-decoration: underline;

The changes to this file are not wanted as they affect the Bookmark and History sidebar which aren't in the Organizer.

::: browser/themes/osx/places/organizer.css
@@ -10,5 @@
>    background-color: transparent;
>    border-color: transparent;
>  }
>  
> -#placesList > treechildren::-moz-tree-row(selected) {  

Please avoid whitespace changes that are unrelated to the patch to avoid changing blame.

::: browser/themes/windows/places/places.css
@@ -16,5 @@
> -}
> -
> -.sidebar-placesTreechildren::-moz-tree-cell-text(leaf, hover) {
> -  cursor: pointer;
> -  text-decoration: underline;

The changes to this file are not wanted as they affect the Bookmark and History sidebar which aren't in the Organizer.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/93c4d9d7ad46

Comment 5

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:29.0) Gecko/20100101 Firefox/29.0

Verified as fixed on Firefox 29 beta 1 (build ID: 20140318013849).