939004 - don't uselessly listen for earlyformsubmit notifications in formSubmitListener.js

Status: RESOLVED INVALID

(Toolkit :: Form Manager, defect)

Description

[Nathan Froyd [:froydnj]]

I don't think we even send these notifications anymore.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: don't uselessly listen for earlyformsubmit notifications in formSubmitListener.js

It doesn't look like we send these notifications, and our observe method
doesn't handle them anyway.  Just delete the code and save a little memory.

Comment 2

[Justin Dolske [:Dolske]]

Uhh. Then how is the observer here ever going to be invoked?

See also http://mxr.mozilla.org/mozilla-central/source/content/html/content/src/HTMLFormElement.cpp#873

Did you run tests with this?

Comment 3

[Justin Dolske [:Dolske]]

[Note that nsIFormSubmitObserver uses notify(), not observe()]

Comment 4

[Nathan Froyd [:froydnj]]

(In reply to Justin Dolske [:Dolske] from comment #2)
> Uhh. Then how is the observer here ever going to be invoked?
> 
> See also
> http://mxr.mozilla.org/mozilla-central/source/content/html/content/src/
> HTMLFormElement.cpp#873
> 
> Did you run tests with this?

Oh man.  That's unfortunate.  Oh well.