[Keyboard]visual keyboard switcher status indicator

RESOLVED FIXED

Status

Firefox OS
Gaia::Keyboard
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gasolin@mozilla.com, Assigned: gasolin@mozilla.com)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(6 attachments, 3 obsolete attachments)

(Assignee)

Description

5 years ago
From bug 936395 Comment 11

While input text, we can switch to different keyboard via pull down the notifications and click the keyboard swicher. But currently there is no visual indicator to help user recognize there's a way to change in keyboard notification bar.

Expect:

Need to be designed status indicator that help user to know there's an option to change keyboard

Comment 1

5 years ago
As discussed with Fred & Mike,
Fang will release a dedicate icon for keyboard indicator on notification bar, 
and this indicator is expected to be placed on the left side of notification bar.

(In reply to Fred Lin [:gasolin] from comment #0)
> From bug 936395 Comment 11
> 
> While input text, we can switch to different keyboard via pull down the
> notifications and click the keyboard swicher. But currently there is no
> visual indicator to help user recognize there's a way to change in keyboard
> notification bar.
> 
> Expect:
> 
> Need to be designed status indicator that help user to know there's an
> option to change keyboard
(Assignee)

Updated

5 years ago
Assignee: nobody → gasolin
(Assignee)

Updated

5 years ago
blocking-b2g: --- → 1.3?

Comment 2

5 years ago
Created attachment 8334441 [details]
Keyboard_icon.zip

Hi,
Please see the attachment file for keyboard icon.
Thanks!
(Assignee)

Comment 3

5 years ago
Hi Eric, could you help put this into the statusbar icon sprite?
Flags: needinfo?(epang)
(In reply to Fred Lin [:gasolin] from comment #3)
> Hi Eric, could you help put this into the statusbar icon sprite?

Hi Fred, I'm going to redirect this to Amy since I know she recently worked on updating the status bar icon sprite.  Looks like we've run out of space on the sprite.  Fred should Amy add a new row to the sprite?
Flags: needinfo?(epang) → needinfo?(amylee.design)
(Assignee)

Comment 5

5 years ago
Yes if possible. Or maybe there's a space right of the green battery?
(In reply to Fred Lin [:gasolin] from comment #5)
> Yes if possible. Or maybe there's a space right of the green battery?

yes that works :)

Comment 7

5 years ago
Created attachment 8334557 [details]
StatusBar_Keyboard_Sprite.zip

Hi, 

Attached are the sprites with the keyboard icon added. Let me know if you need anything else.
Flags: needinfo?(amylee.design)
(Assignee)

Comment 8

5 years ago
Hi Amy, its a bit hard to allocate keyboard icon in this sprite. Could you align the keyboard icon to right, vertical align with the bell icon in next line? then we can use same breakpoint for it. thanks

Comment 9

5 years ago
Created attachment 8335033 [details]
icon_keyboard@2x.png

Hi Fred,
I've attached 2x icon~Thanks!
(Assignee)

Comment 10

5 years ago
Created attachment 8335055 [details]
WIP screenshot

I use play icon for test and it could be shown correctly when there's a keyboard IME switcher.

The weird thing is the battery icon is not shown correctly, maybe due to we put keyboard icon after that.

Please provide icon with keyboard icon align to right, and icon that keyboard in a new row if convenient. I could test if either way works in same time and report which set we really need for this issue. thanks
Created attachment 8335324 [details]
Keyboard_icon_v2.zip

Hi Fred, 

I've attached 2 versions of the sprite sheet with the keyboard icon aligned to the bell icon and another version where it's in a new row. Please let me know which one works best. 

Thanks
(Assignee)

Comment 12

5 years ago
Created attachment 8335339 [details]
keyboard icon in left

The keyboard icon aligned to the bell icon works!

Please also provide the 2x sprite (fang provided that 2x icon). thanks!
(Assignee)

Comment 13

5 years ago
Created attachment 8335743 [details] [review]
pull request redirect to github

Codes are done. Will update 2x icons sprite once its available
Attachment #8334557 - Attachment is obsolete: true
Attachment #8335055 - Attachment is obsolete: true
Attachment #8335743 - Flags: review?(timdream)
(In reply to Fred Lin [:gasolin] from comment #13)
> Created attachment 8335743 [details] [review]
> pull request redirect to github
> 
> Codes are done. Will update 2x icons sprite once its available

Hi Fred, 

We are no longer supporting 2x scaled graphics. What is the 2x sprite being used for? These are the devices we are supporting and the scaled graphics we have for them:

HVGA 320x480 (All our in market devices… unagi, leo, inari, etc…)
Scale Factor 1x

WVGA 480x800 (Helix)
Scale Factor 1.5x

FWVGA 480x854 (new reference device)
Scale Factor 1.5x

WXGA 1280x800 (Flatfish)
Scale Factor 1x and 1.5x
Flags: needinfo?(gasolin)
(Assignee)

Comment 15

5 years ago
I think there's no 2x device yet, but there's a 2x sprite in the source and it seems provide the same set of icons as 1x, 1.5x.
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/style/statusbar/images/icons%402x.png

So the possible way is either remove the existing 2x sprite or replace it with new icons.
Flags: needinfo?(gasolin)
Hi Fred, 

If the 2x sprite isn't being used anywhere, I think it would be safe to remove it as long as it doesn't break anything.
(Assignee)

Comment 17

5 years ago
I'll remove the 2x image, thanks for clarify.
Comment on attachment 8335743 [details] [review]
pull request redirect to github

Could you rebase the patch? Thanks!
Attachment #8335743 - Flags: review?(timdream)
(Assignee)

Comment 19

5 years ago
@Amy, since Bug 933206 Update the Battery Icons 

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/style/statusbar/images/icons%401.5x.png

Could you provide new 1x and 1.5x image base on the new set?

thanks
Flags: needinfo?(amylee.design)
Hi Fred, 

The sprites I provided are from the new set with updated battery icons.


(In reply to Fred Lin [:gasolin] from comment #19)
> @Amy, since Bug 933206 Update the Battery Icons 
> 
> https://github.com/mozilla-b2g/gaia/blob/master/apps/system/style/statusbar/
> images/icons%401.5x.png
> 
> Could you provide new 1x and 1.5x image base on the new set?
> 
> thanks
Flags: needinfo?(amylee.design)
(Assignee)

Comment 21

5 years ago
Comment on attachment 8335743 [details] [review]
pull request redirect to github

@Amy, thanks for help!

Tim, I've rebased the code, please review it again
Attachment #8335743 - Flags: review?(timdream)
Hey Fred,

we land Bug 933206 and the battery icons there are different from:
https://github.com/gasolin/gaia/blob/00d1a7edecad046aaf1e9cf46cd16576bb850ec5/apps/system/style/statusbar/images/icons.png
and 
https://github.com/gasolin/gaia/blob/00d1a7edecad046aaf1e9cf46cd16576bb850ec5/apps/system/style/statusbar/images/icons%401.5x.png

also we will land Bug 939272 soon (Amy works over the sprites) and we will provide the right sprites for you soon.
Depends on: 939272
(Assignee)

Comment 23

5 years ago
Thanks pavel, I'll wait for new sprites
Comment on attachment 8335743 [details] [review]
pull request redirect to github

I am very sorry but it looks like you would have to rebase it again.
Attachment #8335743 - Flags: review?(timdream)
(Assignee)

Comment 25

5 years ago
@amy please provide update icon sets based on Bug 939272, thanks!
Flags: needinfo?(amylee.design)
Created attachment 8338552 [details]
StatusBar_Sprite_v1.3.zip

Hi, 

Attached is the updated status bar sprite with new dimensions
Flags: needinfo?(amylee.design)
Created attachment 8338814 [details]
StatusBar_Sprite_v1.3_2.zip

Hi, 

I made a minor adjustment to the alignment of one of the icons to the @1 sprite. Can you please use this version. Thanks!
Attachment #8338552 - Attachment is obsolete: true
(Assignee)

Comment 28

5 years ago
Comment on attachment 8335743 [details] [review]
pull request redirect to github

update to final icon sets and rebased the code, 

please kindly review it again, thanks!
Attachment #8335743 - Flags: review?(timdream)
Attachment #8335743 - Flags: review?(timdream) → review+
(Assignee)

Comment 29

5 years ago
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/204d32ec1dfa27d87b8ee43ae17b65c005c52b45

thanks!
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
--- since the bug has already made to v1.3.
blocking-b2g: 1.3? → ---
(Assignee)

Updated

5 years ago
Blocks: 950082
You need to log in before you can comment on or make changes to this bug.