Closed Bug 939022 Opened 6 years ago Closed 6 years ago

[Bluetooth] Implement bluedroid BluetoothUtils

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ben.tian, Assigned: ben.tian)

Details

Attachments

(3 files, 3 obsolete files)

Per bug 938521 comment 2, we need to rewrite BluetoothUtils as a class and implement BluetoothUtilsBluedroid that inherits it. BluetoothUtilsBluedroid should include bluedroid-specific utility functions (GetBtInterface and StringToBdAddressType) that are required by profile managers.
Summary: [Bluetooth] Implement BluetoothUtilsBluedroid → [Bluetooth] Implement bluedroid BluetoothUtils
Assignee: nobody → btian
Attachment #8345168 - Flags: review?(echou)
Upload correct patch.
Attachment #8345168 - Attachment is obsolete: true
Attachment #8345168 - Flags: review?(echou)
Attachment #8345169 - Flags: review?(echou)
Changes:
- Move GetBluetoothInterface and StringBdAddress conversion functions into BluetoothUtils
- Remove unused functions
Attachment #8345170 - Flags: review?(echou)
Comment on attachment 8345169 [details] [diff] [review]
[final] Patch 1/3: Move BluetoothUtils files, r=echou

Review of attachment 8345169 [details] [diff] [review]:
-----------------------------------------------------------------

Please remember to touch CLOBBER to trigger clean build on tinderbox.
Attachment #8345169 - Flags: review?(echou) → review+
Attachment #8345169 - Attachment description: Patch 1/2 (v2): Move BluetoothUtils files → [final] Patch 1/2: Move BluetoothUtils files, r=echou
Attachment #8345169 - Attachment description: [final] Patch 1/2: Move BluetoothUtils files, r=echou → [final] Patch 1/3: Move BluetoothUtils files, r=echou
Attachment #8345170 - Attachment description: Patch 2/2 (v1): Customize BluetoothUtils for bluedroid → Patch 2/3 (v1): Customize BluetoothUtils for bluedroid
Attached patch Patch 3/3 (v1): clobber change (obsolete) — Splinter Review
Attachment #8347922 - Flags: review?(echou)
Comment on attachment 8345170 [details] [diff] [review]
[final] Patch 2/3: Customize BluetoothUtils for bluedroid, r=echou

Review of attachment 8345170 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks.
Attachment #8345170 - Flags: review?(echou) → review+
Comment on attachment 8347922 [details] [diff] [review]
Patch 3/3 (v1): clobber change

Review of attachment 8347922 [details] [diff] [review]:
-----------------------------------------------------------------

Ready to go. :)
Attachment #8347922 - Flags: review?(echou) → review+
Comment on attachment 8345169 [details] [diff] [review]
[final] Patch 1/3: Move BluetoothUtils files, r=echou

Review of attachment 8345169 [details] [diff] [review]:
-----------------------------------------------------------------

This should use 'hg mv' to preserve blame.
Attachment #8345169 - Flags: review-
Comment on attachment 8347922 [details] [diff] [review]
Patch 3/3 (v1): clobber change

Review of attachment 8347922 [details] [diff] [review]:
-----------------------------------------------------------------

Why is this necessary? Did you file a bug about it?
(In reply to :Ms2ger from comment #9)
> Comment on attachment 8347922 [details] [diff] [review]
> Patch 3/3 (v1): clobber change
> 
> Review of attachment 8347922 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Why is this necessary? Did you file a bug about it?

It originates from bug bug 915533 comment 22. The sheriff backed out my file-relocation patch for non-clean build break, and suggested us touch clobber to trigger clean build after file relocation.

Let us know if you have better suggestion. Thanks.
Revise based on comment 8. Thanks for the advice.
Attachment #8345169 - Attachment is obsolete: true
Attachment #8347974 - Flags: review?(Ms2ger)
Comment on attachment 8347974 [details] [diff] [review]
[final] Patch 1/3: Move BluetoothUtils files, r=echou

Thanks, much appreciated.
Attachment #8347974 - Flags: review?(Ms2ger)
Attachment #8347974 - Attachment description: Patch 1/3 (v3): Move BluetoothUtils files → [final] Patch 1/3: Move BluetoothUtils files, r=echou
Attachment #8345170 - Attachment description: Patch 2/3 (v1): Customize BluetoothUtils for bluedroid → [final] Patch 2/3: Customize BluetoothUtils for bluedroid, r=echou
Rebase clobber change.
Attachment #8347922 - Attachment is obsolete: true
Attachment #8351071 - Attachment description: [final] Patch 3/3: clobber changeutil-clobber2.patch, r=echou → [final] Patch 3/3: clobber change, r=echou
You need to log in before you can comment on or make changes to this bug.