[Bluetooth] Implement bluedroid BluetoothUtils

RESOLVED FIXED

Status

Firefox OS
Bluetooth
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: btian, Assigned: btian)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 3 obsolete attachments)

(Assignee)

Description

4 years ago
Per bug 938521 comment 2, we need to rewrite BluetoothUtils as a class and implement BluetoothUtilsBluedroid that inherits it. BluetoothUtilsBluedroid should include bluedroid-specific utility functions (GetBtInterface and StringToBdAddressType) that are required by profile managers.
(Assignee)

Updated

4 years ago
Summary: [Bluetooth] Implement BluetoothUtilsBluedroid → [Bluetooth] Implement bluedroid BluetoothUtils
(Assignee)

Comment 1

4 years ago
Created attachment 8345168 [details] [diff] [review]
Patch 1/2 (v1): Move BluetoothUtils files
Assignee: nobody → btian
Attachment #8345168 - Flags: review?(echou)
(Assignee)

Comment 2

4 years ago
Created attachment 8345169 [details] [diff] [review]
[final] Patch 1/3: Move BluetoothUtils files, r=echou

Upload correct patch.
Attachment #8345168 - Attachment is obsolete: true
Attachment #8345168 - Flags: review?(echou)
Attachment #8345169 - Flags: review?(echou)
(Assignee)

Comment 3

4 years ago
Created attachment 8345170 [details] [diff] [review]
[final] Patch 2/3: Customize BluetoothUtils for bluedroid, r=echou

Changes:
- Move GetBluetoothInterface and StringBdAddress conversion functions into BluetoothUtils
- Remove unused functions
Attachment #8345170 - Flags: review?(echou)
Comment on attachment 8345169 [details] [diff] [review]
[final] Patch 1/3: Move BluetoothUtils files, r=echou

Review of attachment 8345169 [details] [diff] [review]:
-----------------------------------------------------------------

Please remember to touch CLOBBER to trigger clean build on tinderbox.
Attachment #8345169 - Flags: review?(echou) → review+
(Assignee)

Updated

4 years ago
Attachment #8345169 - Attachment description: Patch 1/2 (v2): Move BluetoothUtils files → [final] Patch 1/2: Move BluetoothUtils files, r=echou
(Assignee)

Updated

4 years ago
Attachment #8345169 - Attachment description: [final] Patch 1/2: Move BluetoothUtils files, r=echou → [final] Patch 1/3: Move BluetoothUtils files, r=echou
(Assignee)

Updated

4 years ago
Attachment #8345170 - Attachment description: Patch 2/2 (v1): Customize BluetoothUtils for bluedroid → Patch 2/3 (v1): Customize BluetoothUtils for bluedroid
(Assignee)

Comment 5

4 years ago
Created attachment 8347922 [details] [diff] [review]
Patch 3/3 (v1): clobber change
Attachment #8347922 - Flags: review?(echou)
Comment on attachment 8345170 [details] [diff] [review]
[final] Patch 2/3: Customize BluetoothUtils for bluedroid, r=echou

Review of attachment 8345170 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks.
Attachment #8345170 - Flags: review?(echou) → review+
Comment on attachment 8347922 [details] [diff] [review]
Patch 3/3 (v1): clobber change

Review of attachment 8347922 [details] [diff] [review]:
-----------------------------------------------------------------

Ready to go. :)
Attachment #8347922 - Flags: review?(echou) → review+
Comment on attachment 8345169 [details] [diff] [review]
[final] Patch 1/3: Move BluetoothUtils files, r=echou

Review of attachment 8345169 [details] [diff] [review]:
-----------------------------------------------------------------

This should use 'hg mv' to preserve blame.
Attachment #8345169 - Flags: review-
Comment on attachment 8347922 [details] [diff] [review]
Patch 3/3 (v1): clobber change

Review of attachment 8347922 [details] [diff] [review]:
-----------------------------------------------------------------

Why is this necessary? Did you file a bug about it?
(Assignee)

Comment 10

4 years ago
(In reply to :Ms2ger from comment #9)
> Comment on attachment 8347922 [details] [diff] [review]
> Patch 3/3 (v1): clobber change
> 
> Review of attachment 8347922 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Why is this necessary? Did you file a bug about it?

It originates from bug bug 915533 comment 22. The sheriff backed out my file-relocation patch for non-clean build break, and suggested us touch clobber to trigger clean build after file relocation.

Let us know if you have better suggestion. Thanks.
(Assignee)

Comment 11

4 years ago
Created attachment 8347974 [details] [diff] [review]
[final] Patch 1/3: Move BluetoothUtils files, r=echou

Revise based on comment 8. Thanks for the advice.
Attachment #8345169 - Attachment is obsolete: true
Attachment #8347974 - Flags: review?(Ms2ger)
Comment on attachment 8347974 [details] [diff] [review]
[final] Patch 1/3: Move BluetoothUtils files, r=echou

Thanks, much appreciated.
Attachment #8347974 - Flags: review?(Ms2ger)
(Assignee)

Updated

4 years ago
Attachment #8347974 - Attachment description: Patch 1/3 (v3): Move BluetoothUtils files → [final] Patch 1/3: Move BluetoothUtils files, r=echou
(Assignee)

Updated

4 years ago
Attachment #8345170 - Attachment description: Patch 2/3 (v1): Customize BluetoothUtils for bluedroid → [final] Patch 2/3: Customize BluetoothUtils for bluedroid, r=echou
(Assignee)

Comment 13

4 years ago
Created attachment 8351071 [details] [diff] [review]
[final] Patch 3/3: clobber change, r=echou

Rebase clobber change.
Attachment #8347922 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Attachment #8351071 - Attachment description: [final] Patch 3/3: clobber changeutil-clobber2.patch, r=echou → [final] Patch 3/3: clobber change, r=echou
(Assignee)

Comment 14

4 years ago
try server: https://tbpl.mozilla.org/?tree=Try&rev=5d6ae3016cbf
(Assignee)

Comment 15

4 years ago
https://hg.mozilla.org/integration/b2g-inbound/rev/4c67ed9a5cfe
https://hg.mozilla.org/integration/b2g-inbound/rev/9177a8846a2b
https://hg.mozilla.org/integration/b2g-inbound/rev/cd09c472c326
https://hg.mozilla.org/mozilla-central/rev/4c67ed9a5cfe
https://hg.mozilla.org/mozilla-central/rev/9177a8846a2b
https://hg.mozilla.org/mozilla-central/rev/cd09c472c326
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.