Closed Bug 939042 Opened 11 years ago Closed 11 years ago

Remove library building related variables in directories that build no C/C++ sources

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla28

People

(Reporter: glandium, Assigned: glandium)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Remove library building related variables in directories that build no C/C++ sources
3.95 KB, patch
mshal
: review+
Details | Diff | Splinter Review 
Yeah, we do have that. Probably comes from cargo culting.
or history.
Is there some other patch in your queue that removes libfeed_s from toolkit/components/build/Makefile.in? Right now this doesn't build because it's missing.
Flags: needinfo?(mh+mozilla)
(In reply to Michael Shal [:mshal] from comment #3)
> Is there some other patch in your queue that removes libfeed_s from
> toolkit/components/build/Makefile.in? Right now this doesn't build because
> it's missing.

See bug 935881.
Flags: needinfo?(mh+mozilla)
Not sure how I missed that - I looked at the bug, but maybe I missed one of the patches.
Attachment #832792 - Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/e50ec1860930
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: