Unfocused highlight has insufficient contrast in folder pane

RESOLVED WORKSFORME

Status

Thunderbird
Theme
RESOLVED WORKSFORME
4 years ago
a year ago

People

(Reporter: Gerhard Großmann, Unassigned)

Tracking

24 Branch
x86_64
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Reporter)

Description

4 years ago
Created attachment 832858 [details]
Unfocused highlights are to light

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20131028113308

Steps to reproduce:

Select a mail folder, select a mail, the click on the mail body so that the highlighted folder and message is unfocused


Actual results:

The color of the unfocused highlights was changed in an earlier version of Thunderbird. Now it hasn’t enough contrast to the background of the folder pane. The selected folder is difficult to identify.


Expected results:

The unfocused highlight still should have a color with enough contrast to the background.

This bug is linked to https://bugzilla.mozilla.org/show_bug.cgi?id=811920. The altered highlight color actually also hadn’t enough contrast to the zebrastriping of the message list. That bug was “patched” by removing the zebra striping completely. Please don’t do such a radical and imprudent patch here again.

My suggestion: darken the unfocused highlight and bring back the zebra striping, too. Other ideas?
For the elements we are using the system colors. Maybe it's less readable through the grain we are using in the background. I'll check if this could be the cause.
Blocks: 811920
Component: Folder and Message Lists → Theme
(Reporter)

Comment 2

4 years ago
Created attachment 832867 [details]
comparison-nautilus-thunderbird.png

I have to add that this problem only occurs when the user set the Gtk theme to Radiance or Ambiance. With Adwaita (the standard?) the unfocused highlight barely changes its color and differs sufficiently from everything around.

Attached is an image how the unfocused colors compare in Nautilus and Thunderbird.
Created attachment 833024 [details]
Screenshot without the grain in FolderTree with Ambiance theme

Removing the grain background makes the inactive treechildren already better visible.

But changing or removing the grain will be done in bug 935023. Let's see what this bug needs then after fixing bug 935023.
Blocks: 935023

Comment 4

3 years ago
(In reply to Richard Marti (:Paenglab) from comment #3)
>...
> But changing or removing the grain will be done in bug 935023. Let's see
> what this bug needs then after fixing bug 935023.

Gerhard, these are fixed i nversion 31. How does it look to you?
Flags: needinfo?(gerhard.grossmann)
(Reporter)

Comment 5

3 years ago
Thank you for the inquiry! This gave me the opportunity to make a before/after screen shot. In the meantime I’ve upgraded my system to Ubuntu Trusty Tahr (14.04) and use the system colors (where this bug exists, too).

Now without the grain the unfocused highlight is slightly better visible. If the contrast of #E5E3E1 on #EEEEEE (= 1.1 according to http://leaverou.github.io/contrast-ratio/#%23E5E3E1-on-%23EEEEEE) is considered as sufficient enough for unfocused highlighting, this bug could be closed.

(For me I’ve written a userChrome style sheet which darkens the highlight to #D9D5D0. That’s better visible on my LCD display.)
Flags: needinfo?(gerhard.grossmann)
(Reporter)

Comment 6

3 years ago
Created attachment 8460830 [details]
Comparision between Thunderbird 24 and 31
Richard, Can comment 5 be done?
Flags: needinfo?(richard.marti)
(In reply to Wayne Mery (:wsmwk, NI for questions) from comment #7)
> Richard, Can comment 5 be done?

Unfortunately not. We use system colors and can't set one special color for one theme, especially on Linux with the huge amount of themes.

For the folderTree background we use the -moz-OddTreeRow color - a standard color. Also the unfocused highlight is the system color. When the contrast is too low, then it's a Linux theme issue.

I close as WORKSFORME because the actual contrast is enough on other themes I tested.
Status: UNCONFIRMED → RESOLVED
Last Resolved: a year ago
Flags: needinfo?(richard.marti)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.