939112 - Newsletter signup forms should only show languages in which they're available

Status: VERIFIED FIXED

(www.mozilla.org :: Newsletters, defect, P1)

Description

[Paul [:pmac] McLanahan]

The language drop down menu for newsletter signup should be dynamic based on the languages the newsletter supports. This information is available via the basket API.

Comment 1

[Paul [:pmac] McLanahan]

Attachment: pull request

This is a major overhaul of how newsletter forms work on bedrock. It may take a few days to review.

Comment 2

[Jessilyn Davis]

Pmac to merge and have on dev for Rbillings to test on Monday.

Goal launch date: Wed, Dec 4

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/c72ef739fbdebe357a87394b609ee7bb06652c94
Fix bug 939112: Newsletter form choices only supported.

The newsletter forms will now only display choices
for the languages supported by the specific newsletter.

Removes the newsletter middleware and moves form processing
into the template helper function.

Also fix bug 914680: Enable language choice for hacks.

https://github.com/mozilla/bedrock/commit/d0ecc4f4cc61c46302983f576082de4ad7479231
Merge pull request #1419 from pmclanahan/newsletters-show-only-available-languages-939112

Fix bug 939112: Newsletter form choices only supported.

Comment 4

[Paul [:pmac] McLanahan]

Wanting to push this out today. It's blocking some other things that are important to get into prod. Are we good with the testing or is more required?

Comment 5

[Rebecca Billings [:rbillings]]

Verified list of supported languages displays correctly on dev

Comment 6

[Paul [:pmac] McLanahan]

This is in prod.

Comment 7

[Rebecca Billings [:rbillings]]

Verified on prod.