939118 - DisconnectStep shouldn't do anything if the slave is in the middle of a graceful shutdown

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

Attachment: don't reboot when graceful shutdown is set

Arguably, if you've requested a graceful shutdown of a slave, you don't want it to reboot. It's kindof pointless, really, and harmful if you didn't or can't disable it in slavealloc for some reason. Also this would help a lot with bug 932392.

I'm a little biased in my desire for this, so what do folks think? I tested this in staging.

Comment 1

[[e-mail] (:bhearsum)]

Rail just pointed out a more solid use case for this: it will allow us to grab files before puppet cleans them up at start-up time. This won't help with nightly builds where we rm the dir as part of the build, but it will help in cases where there's files in temp dirs or other locations like that.

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 832925 [details] [diff] [review]
don't reboot when graceful shutdown is set

sgtm :-)

Comment 3

[Justin Wood (:Callek)]

something[s] here made it to production