Closed Bug 939121 Opened 7 years ago Closed 7 years ago

Build netwerk/ipc, protocol, socket, srtp, and wifi in unified mode

Categories

(Core :: Networking, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Within the netwerk directory, the ipc, protocol/{data,device,file,viewsource,websocket,wyciwyg}, socket, srtp, and wifi directories can be built in unified mode without code changes. The other netwerk directories will need fixes before they can be unified.

https://tbpl.mozilla.org/?tree=Try&rev=3bd28d7a463e
Attachment #832933 - Flags: review?(mcmanus)
Heh, I wrote part of this patch last night.  Thanks for stealing my thunder.  :P
so how much does this change impact end to end clobber build time?
About 4 whole seconds! ;)

On my MacBook Pro, after touching all *.c* files in the netwerk directory, mach build takes 124 seconds without this patch and 120 seconds with. These measurements were consistent across multiple test runs.
Comment on attachment 832933 [details] [diff] [review]
unify-some-netwerk.patch

Review of attachment 832933 [details] [diff] [review]:
-----------------------------------------------------------------

r=mcmanus .. I really appreciate the recent changes to the build system - its really been a productivity boost and I'm not going to stand in the way of what you think is another good idea.

I gotta say though that I'm skeptical about this one.
Attachment #832933 - Flags: review?(mcmanus) → review+
Waiting for bug 938844 to land UNIFIED_SOURCES support for .mm files.
Depends on: 938844
Blocks: unified
https://hg.mozilla.org/mozilla-central/rev/b86f07b08a8b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.