939121 - Build netwerk/ipc, protocol, socket, srtp, and wifi in unified mode

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: unify-some-netwerk.patch

Within the netwerk directory, the ipc, protocol/{data,device,file,viewsource,websocket,wyciwyg}, socket, srtp, and wifi directories can be built in unified mode without code changes. The other netwerk directories will need fixes before they can be unified.

https://tbpl.mozilla.org/?tree=Try&rev=3bd28d7a463e

Comment 1

[(no longer active)]

Heh, I wrote part of this patch last night.  Thanks for stealing my thunder.  :P

Comment 2

[Patrick McManus [:mcmanus]]

so how much does this change impact end to end clobber build time?

Comment 3

[Chris Peterson [:cpeterson]]

About 4 whole seconds! ;)

On my MacBook Pro, after touching all *.c* files in the netwerk directory, mach build takes 124 seconds without this patch and 120 seconds with. These measurements were consistent across multiple test runs.

Comment 4

[Patrick McManus [:mcmanus]]

Comment on attachment 832933 [details] [diff] [review]
unify-some-netwerk.patch

Review of attachment 832933 [details] [diff] [review]:
-----------------------------------------------------------------

r=mcmanus .. I really appreciate the recent changes to the build system - its really been a productivity boost and I'm not going to stand in the way of what you think is another good idea.

I gotta say though that I'm skeptical about this one.

Comment 5

[Chris Peterson [:cpeterson]]

Waiting for bug 938844 to land UNIFIED_SOURCES support for .mm files.

Comment 6

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b86f07b08a8b

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b86f07b08a8b